[GitHub] [cassandra] bereng commented on a diff in pull request #1643: Cassandra 17232 4.0

[GitBox <gi...@apache.org>]

bereng commented on code in PR #1643:
URL: https://github.com/apache/cassandra/pull/1643#discussion_r882455601


##########
test/unit/org/apache/cassandra/db/commitlog/CommitLogTest.java:
##########
@@ -118,6 +119,8 @@ public static Collection<Object[]> generateData()
 
     public static void beforeClass() throws ConfigurationException
     {
+        KEYSPACE1 = "CommitLogTest" + ksIter;
+        KEYSPACE2 = "CommitLogTestNonDurable" + ksIter++;

Review Comment:
   That's what logic dictates yes. But when using the `RepeatableRunner` it does indeed fail hence why I went this route:
   ```
   [junit-timeout] Testcase: org.apache.cassandra.db.commitlog.GroupCommitLogTest:	Caused an ERROR
   [junit-timeout] Cannot add existing keyspace "CommitLogTest"
   [junit-timeout] org.apache.cassandra.exceptions.AlreadyExistsException: Cannot add existing keyspace "CommitLogTest"
   [junit-timeout] 	at org.apache.cassandra.schema.SchemaTestUtil.announceNewKeyspace(SchemaTestUtil.java:47)
   [junit-timeout] 	at org.apache.cassandra.SchemaLoader.createKeyspace(SchemaLoader.java:267)
   [junit-timeout] 	at org.apache.cassandra.db.commitlog.CommitLogTest.beforeClass(CommitLogTest.java:164)
   [junit-timeout] 	at org.apache.cassandra.db.commitlog.GroupCommitLogTest.setCommitLogModeDetails(GroupCommitLogTest.java:47)
   [junit-timeout] 	at org.apache.cassandra.RepeatableRunner.run(RepeatableRunner.java:84)
   ```
   
   In any case this PR is wrong anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org