You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/08/22 11:44:58 UTC
[PR] Remove useless pipeline DataNodeUtils [shardingsphere]
terrymanu opened a new pull request, #39557:
URL: https://github.com/apache/shardingsphere/pull/39557
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless pipeline DataNodeUtils [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39557:
URL: https://github.com/apache/shardingsphere/pull/39557#issuecomment-5380276278
### Result
**Review Result: Mergeable**
Head `bdc99af75b50fee688f969109581fdc2fb25e351` completely removes the redundant pipeline utility while preserving its parsing behavior through `DataNode(String)`.
### Evidence
- The removed wrapper delegated directly to `new DataNode(text)` at the base head; the replacements in [`JobDataNodeEntry.java`](https://github.com/apache/shardingsphere/blob/bdc99af75b50fee688f969109581fdc2fb25e351/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/datanode/JobDataNodeEntry.java#L45-L49) and [`MigrationDataConsistencyChecker.java`](https://github.com/apache/shardingsphere/blob/bdc99af75b50fee688f969109581fdc2fb25e351/kernel/data-pipeline/scenario/migration/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/check/consistency/MigrationDataConsistencyChecker.java#L111-L168) therefore preserve validation, schema parsing, and exception behavior.
- Repository-wide inspection found no remaining direct, reflective, SPI, resource, or generated consumer of the removed pipeline class.
- Scoped core and migration tests: exit `0`; 326 tests passed.
- Owning `DataNodeTest`: exit `0`; 42 tests passed.
- Scoped package build: exit `0`; the rebuilt core JAR does not contain `DataNodeUtils.class`.
- `git diff --check`: exit `0`.
### Coverage
- Base/merge-base: `44dcc3afa867e387c40d3ec64ccc8748931faaa9`.
- GitHub’s authoritative four-file list matched the local triple-dot scope; all four files were reviewed.
- Covered clusters: parser-owner convergence and removal, persisted job-data-node unmarshalling, and migration consistency-check parsing.
- Completed root-cause/behavior, blast-radius/contracts, tests/runtime/operations, latest-delta, and full-scope convergence passes.
- No unresolved evidence gaps remain.
- This is a code-scope result only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless pipeline DataNodeUtils [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39557:
URL: https://github.com/apache/shardingsphere/pull/39557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org