You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2014/10/10 23:46:24 UTC

Review Request 26576: Add Knox as a managed service in Ambari.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/
-----------------------------------------------------------

Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-7685
    https://issues.apache.org/jira/browse/AMBARI-7685


Repository: ambari


Description
-------

This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 

Remaining tasks for knox integration after this patch is committed:
# Support for knox in kerberized ambari cluster.
# Support for knox in HDP-2.2 stack.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/knox-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/ldap.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/KNOX/test_knox_gateway.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.1/configs/default.json cdb70f4 
  ambari-web/app/controllers/main/service/item.js 8990a39 
  ambari-web/app/data/HDP2/site_properties.js 19299bc 
  ambari-web/app/messages.js 6d8e0fc 
  ambari-web/app/models/service_config.js 595f604 
  ambari-web/app/models/stack_service.js 0d4d30e 
  ambari-web/app/utils/ajax/ajax.js cc3e325 
  ambari-web/app/utils/config.js b3d363a 
  ambari-web/app/views/main/service/item.js 929c212 
  ambari-web/test/controllers/main/service/item_test.js 4f94eda 

Diff: https://reviews.apache.org/r/26576/diff/


Testing
-------

tested e2e


Thanks,

Jaimin Jetly


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/#review56233
-----------------------------------------------------------


Very good to see this.
One thing is that I don't think we should be introducing a new service to the 2.1 stack; it should just be for 2.2 and onward.

- Yusaku Sako


On Oct. 10, 2014, 9:46 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26576/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 9:46 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7685
>     https://issues.apache.org/jira/browse/AMBARI-7685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 
> 
> Remaining tasks for knox integration after this patch is committed:
> # Support for knox in kerberized ambari cluster.
> # Support for knox in HDP-2.2 stack.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/knox-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/ldap.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/KNOX/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.1/KNOX/test_knox_gateway.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json cdb70f4 
>   ambari-web/app/controllers/main/service/item.js 8990a39 
>   ambari-web/app/data/HDP2/site_properties.js 19299bc 
>   ambari-web/app/messages.js 6d8e0fc 
>   ambari-web/app/models/service_config.js 595f604 
>   ambari-web/app/models/stack_service.js 0d4d30e 
>   ambari-web/app/utils/ajax/ajax.js cc3e325 
>   ambari-web/app/utils/config.js b3d363a 
>   ambari-web/app/views/main/service/item.js 929c212 
>   ambari-web/test/controllers/main/service/item_test.js 4f94eda 
> 
> Diff: https://reviews.apache.org/r/26576/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/#review56279
-----------------------------------------------------------

Ship it!


Ship It!

- Sid Wagle


On Oct. 11, 2014, 1:07 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26576/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 1:07 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7685
>     https://issues.apache.org/jira/browse/AMBARI-7685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 
> 
> Remaining tasks for knox integration after this patch is committed:
> # Support for knox in kerberized ambari cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
>   ambari-web/app/controllers/main/service/item.js 8990a39 
>   ambari-web/app/data/HDP2/site_properties.js 19299bc 
>   ambari-web/app/messages.js 6d8e0fc 
>   ambari-web/app/models/service_config.js 595f604 
>   ambari-web/app/models/stack_service.js 0d4d30e 
>   ambari-web/app/utils/ajax/ajax.js cc3e325 
>   ambari-web/app/utils/config.js b3d363a 
>   ambari-web/app/views/main/service/item.js 929c212 
>   ambari-web/test/controllers/main/service/item_test.js 4f94eda 
> 
> Diff: https://reviews.apache.org/r/26576/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Jaimin Jetly <ja...@hortonworks.com>.

> On Oct. 11, 2014, 2:02 a.m., Yusaku Sako wrote:
> > Thanks for the update.  The new patch looks good to me.
> > The JIRA has the branch-1.7.0 patch with Knox being added to HDP 2.1 still.  Can we fix that as well?

uploaded 2nd revision for the branc-1.7.0 patch


- Jaimin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/#review56272
-----------------------------------------------------------


On Oct. 11, 2014, 1:07 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26576/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 1:07 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7685
>     https://issues.apache.org/jira/browse/AMBARI-7685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 
> 
> Remaining tasks for knox integration after this patch is committed:
> # Support for knox in kerberized ambari cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
>   ambari-web/app/controllers/main/service/item.js 8990a39 
>   ambari-web/app/data/HDP2/site_properties.js 19299bc 
>   ambari-web/app/messages.js 6d8e0fc 
>   ambari-web/app/models/service_config.js 595f604 
>   ambari-web/app/models/stack_service.js 0d4d30e 
>   ambari-web/app/utils/ajax/ajax.js cc3e325 
>   ambari-web/app/utils/config.js b3d363a 
>   ambari-web/app/views/main/service/item.js 929c212 
>   ambari-web/test/controllers/main/service/item_test.js 4f94eda 
> 
> Diff: https://reviews.apache.org/r/26576/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/#review56272
-----------------------------------------------------------


Thanks for the update.  The new patch looks good to me.
The JIRA has the branch-1.7.0 patch with Knox being added to HDP 2.1 still.  Can we fix that as well?

- Yusaku Sako


On Oct. 11, 2014, 1:07 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26576/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 1:07 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7685
>     https://issues.apache.org/jira/browse/AMBARI-7685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 
> 
> Remaining tasks for knox integration after this patch is committed:
> # Support for knox in kerberized ambari cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
>   ambari-web/app/controllers/main/service/item.js 8990a39 
>   ambari-web/app/data/HDP2/site_properties.js 19299bc 
>   ambari-web/app/messages.js 6d8e0fc 
>   ambari-web/app/models/service_config.js 595f604 
>   ambari-web/app/models/stack_service.js 0d4d30e 
>   ambari-web/app/utils/ajax/ajax.js cc3e325 
>   ambari-web/app/utils/config.js b3d363a 
>   ambari-web/app/views/main/service/item.js 929c212 
>   ambari-web/test/controllers/main/service/item_test.js 4f94eda 
> 
> Diff: https://reviews.apache.org/r/26576/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/#review56277
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Oct. 11, 2014, 1:07 a.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26576/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2014, 1:07 a.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-7685
>     https://issues.apache.org/jira/browse/AMBARI-7685
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 
> 
> Remaining tasks for knox integration after this patch is committed:
> # Support for knox in kerberized ambari cluster.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
>   ambari-web/app/controllers/main/service/item.js 8990a39 
>   ambari-web/app/data/HDP2/site_properties.js 19299bc 
>   ambari-web/app/messages.js 6d8e0fc 
>   ambari-web/app/models/service_config.js 595f604 
>   ambari-web/app/models/stack_service.js 0d4d30e 
>   ambari-web/app/utils/ajax/ajax.js cc3e325 
>   ambari-web/app/utils/config.js b3d363a 
>   ambari-web/app/views/main/service/item.js 929c212 
>   ambari-web/test/controllers/main/service/item_test.js 4f94eda 
> 
> Diff: https://reviews.apache.org/r/26576/diff/
> 
> 
> Testing
> -------
> 
> tested e2e
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/
-----------------------------------------------------------

(Updated Oct. 11, 2014, 1:07 a.m.)


Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Bugs: AMBARI-7685
    https://issues.apache.org/jira/browse/AMBARI-7685


Repository: ambari


Description (updated)
-------

This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 

Remaining tasks for knox integration after this patch is committed:
# Support for knox in kerberized ambari cluster.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
  ambari-web/app/controllers/main/service/item.js 8990a39 
  ambari-web/app/data/HDP2/site_properties.js 19299bc 
  ambari-web/app/messages.js 6d8e0fc 
  ambari-web/app/models/service_config.js 595f604 
  ambari-web/app/models/stack_service.js 0d4d30e 
  ambari-web/app/utils/ajax/ajax.js cc3e325 
  ambari-web/app/utils/config.js b3d363a 
  ambari-web/app/views/main/service/item.js 929c212 
  ambari-web/test/controllers/main/service/item_test.js 4f94eda 

Diff: https://reviews.apache.org/r/26576/diff/


Testing
-------

tested e2e


Thanks,

Jaimin Jetly


Re: Review Request 26576: Add Knox as a managed service in Ambari.

Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26576/
-----------------------------------------------------------

(Updated Oct. 11, 2014, 1:07 a.m.)


Review request for Ambari, Srimanth Gunturi, Sid Wagle, and Yusaku Sako.


Changes
-------

updated the ptch to integrate knox only with HDP-2.2 stack


Bugs: AMBARI-7685
    https://issues.apache.org/jira/browse/AMBARI-7685


Repository: ambari


Description
-------

This adds a new stack definition for knox service in HDP-2.1 stack (nagios alerts are integrated for knox gateway daemon). Includes needed UI changes along with unit test. 

Remaining tasks for knox integration after this patch is committed:
# Support for knox in kerberized ambari cluster.
# Support for knox in HDP-2.2 stack.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/files/nagios_alerts.php 0e1e501 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py ec6c885 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-servicegroups.cfg.j2 aee9b15 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/templates/hadoop-services.cfg.j2 f69238e 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ambari-topology.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/gateway-site.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/knox-env.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/ldap-log4j.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/configuration/users-ldif.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/metainfo.xml PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/knox_gateway.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/ldap.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/params.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/service_check.py PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/KNOX/package/scripts/status_params.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py PRE-CREATION 
  ambari-server/src/test/python/stacks/2.2/configs/default.json ce7a379 
  ambari-web/app/controllers/main/service/item.js 8990a39 
  ambari-web/app/data/HDP2/site_properties.js 19299bc 
  ambari-web/app/messages.js 6d8e0fc 
  ambari-web/app/models/service_config.js 595f604 
  ambari-web/app/models/stack_service.js 0d4d30e 
  ambari-web/app/utils/ajax/ajax.js cc3e325 
  ambari-web/app/utils/config.js b3d363a 
  ambari-web/app/views/main/service/item.js 929c212 
  ambari-web/test/controllers/main/service/item_test.js 4f94eda 

Diff: https://reviews.apache.org/r/26576/diff/


Testing
-------

tested e2e


Thanks,

Jaimin Jetly