You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org> on 2018/12/19 17:21:18 UTC
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Bikramjeet Vig has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12110
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
test_insert_large_string uses upto 4GB of untracked memory which results
in random OOMs during exhaustive testing on release builds. Queries run
faster on release builds which might result in a different set of tests
running together when compared to those on debug builds. This can result
in queries requiring more memory running together with
test_insert_large_string and eventually encounter OOM errors.
Testing:
Successfully ran exhaustive tests twice on release build.
Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
---
M tests/query_test/test_insert.py
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/10/12110/1
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1647/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:55:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:29:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
test_insert_large_string uses upto 4GB of untracked memory which results
in random OOMs during exhaustive testing on release builds. Queries run
faster on release builds which might result in a different set of tests
running together when compared to those on debug builds. This can result
in queries requiring more memory running together with
test_insert_large_string and eventually encounter OOM errors.
Testing:
Successfully ran exhaustive tests twice on release build.
Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Reviewed-on: http://gerrit.cloudera.org:8080/12110
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_insert.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 3
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3587/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:29:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 1
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 17:26:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7994: Prevent test insert large string from causing OOM issues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12110 )
Change subject: IMPALA-7994: Prevent test_insert_large_string from causing OOM issues
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c950f6860b2f86865dbc5ce60055175e2c0bebc
Gerrit-Change-Number: 12110
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Dec 2018 21:28:04 +0000
Gerrit-HasComments: No