[jira] [Commented] (CASSANDRA-20708) Add missing test for verifying toRepair fully contained in localRange

["Somyeong Jeon (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17958366#comment-17958366 ] 

Somyeong Jeon commented on CASSANDRA-20708:
-------------------------------------------

The fix is available here:
[https://github.com/Callein/cassandra/tree/CASSANDRA-20708-test-range-intersection]

 

> Add missing test for verifying toRepair fully contained in localRange
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-20708
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20708
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Consistency/Repair
>            Reporter: Somyeong Jeon
>            Assignee: Somyeong Jeon
>            Priority: Normal
>         Attachments: 0001-CASSANDRA-20708-Add-test-for-ActiveRepairService.get.patch
>
>
> Where: `org.apache.cassandra.service.ActiveRepairServiceTest`
> While testing the getNeighbors method in ActiveRepairService, I noticed that it only verifies if the toRepair range intersects with a localRange. However, it does not validate whether the toRepair range is fully contained within the localRange, which could lead to imprecise repairs.
> To address this, I have added a test method named `testGetNeighborsRangeIntersectButNotContained` in the `ActiveRepairServiceTest` class. This test specifically passes a toRepair range that only intersects but is not fully contained in a localRange, ensuring that the expected `IllegalArgumentException` is thrown as intended by the method's contract.
> This strengthens the test coverage for the edge case where an intersecting but not fully contained range is passed to `getNeighbors`.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org