You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morningman (via GitHub)" <gi...@apache.org> on 2023/11/28 13:20:40 UTC
[PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
morningman opened a new pull request, #27718:
URL: https://github.com/apache/doris/pull/27718
## Proposed changes
Issue Number: #19897
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1830232505
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 47.34 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17099304184 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1829914780
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1830033577
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #27718:
URL: https://github.com/apache/doris/pull/27718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1833005045
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1831271675
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1831193829
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1831400527
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.78 seconds
stream load tsv: 571 seconds loaded 74807831229 Bytes, about 124 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.5 seconds inserted 10000000 Rows, about 350K ops/s
storage size: 17099094131 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1829973383
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1830045680
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1830185471
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 9bc1b7e060388214d511881cab0c66bb69e19ea6, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4862 4589 4604 4589
q2 351 146 145 145
q3 1511 1302 1279 1279
q4 1150 1032 933 933
q5 3270 3267 3258 3258
q6 251 132 130 130
q7 1018 523 525 523
q8 2284 2277 2241 2241
q9 7010 6943 6952 6943
q10 3308 3379 3371 3371
q11 339 210 201 201
q12 353 222 221 221
q13 4668 3889 3904 3889
q14 253 215 221 215
q15 582 535 529 529
q16 424 400 393 393
q17 1062 635 643 635
q18 8084 7559 8215 7559
q19 1584 1547 1564 1547
q20 533 373 300 300
q21 3419 2932 2906 2906
q22 366 293 305 293
Total cold run time: 46682 ms
Total hot run time: 42100 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4605 4600 4581 4581
q2 324 225 212 212
q3 3762 3753 3751 3751
q4 2544 2545 2590 2545
q5 6195 6216 6180 6180
q6 249 123 124 123
q7 2626 1984 1960 1960
q8 3742 3704 3696 3696
q9 9423 9439 9471 9439
q10 4068 4167 4153 4153
q11 643 469 479 469
q12 809 652 655 652
q13 4371 3643 3674 3643
q14 284 243 241 241
q15 588 526 528 526
q16 503 467 487 467
q17 2126 2119 2069 2069
q18 9506 8922 9073 8922
q19 1805 1769 1782 1769
q20 2318 2000 1975 1975
q21 7546 6957 7071 6957
q22 641 564 561 561
Total cold run time: 68678 ms
Total hot run time: 64891 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "zddr (via GitHub)" <gi...@apache.org>.
zddr commented on code in PR #27718:
URL: https://github.com/apache/doris/pull/27718#discussion_r1409043916
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/BaseController.java:
##########
@@ -266,11 +266,10 @@ private boolean parseAuthInfo(HttpServletRequest request, ActionAuthorizationInf
authInfo.fullUserName = authString.substring(0, index);
final String[] elements = authInfo.fullUserName.split("@");
if (elements != null && elements.length < 2) {
- authInfo.fullUserName = ClusterNamespace.getFullName(SystemInfoService.DEFAULT_CLUSTER,
- authInfo.fullUserName);
+ authInfo.fullUserName = ClusterNamespace.getNameFromFullName(authInfo.fullUserName);
authInfo.cluster = SystemInfoService.DEFAULT_CLUSTER;
} else if (elements != null && elements.length == 2) {
- authInfo.fullUserName = ClusterNamespace.getFullName(elements[1], elements[0]);
+ authInfo.fullUserName = ClusterNamespace.getNameFromFullName(elements[0]);
authInfo.cluster = elements[1];
Review Comment:
authInfo.cluster do not need remove?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #27718:
URL: https://github.com/apache/doris/pull/27718#discussion_r1409114410
##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/controller/BaseController.java:
##########
@@ -266,11 +266,10 @@ private boolean parseAuthInfo(HttpServletRequest request, ActionAuthorizationInf
authInfo.fullUserName = authString.substring(0, index);
final String[] elements = authInfo.fullUserName.split("@");
if (elements != null && elements.length < 2) {
- authInfo.fullUserName = ClusterNamespace.getFullName(SystemInfoService.DEFAULT_CLUSTER,
- authInfo.fullUserName);
+ authInfo.fullUserName = ClusterNamespace.getNameFromFullName(authInfo.fullUserName);
authInfo.cluster = SystemInfoService.DEFAULT_CLUSTER;
} else if (elements != null && elements.length == 2) {
- authInfo.fullUserName = ClusterNamespace.getFullName(elements[1], elements[0]);
+ authInfo.fullUserName = ClusterNamespace.getNameFromFullName(elements[0]);
authInfo.cluster = elements[1];
Review Comment:
No, I will remove this in next pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](cluster)(step-3) remove cluster related to Auth [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27718:
URL: https://github.com/apache/doris/pull/27718#issuecomment-1833090322
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org