You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "mmustafasenoglu (via GitHub)" <gi...@apache.org> on 2026/06/23 20:36:20 UTC
[PR] fix: reject @ character in header names [trafficserver]
mmustafasenoglu opened a new pull request, #13314:
URL: https://github.com/apache/trafficserver/pull/13314
## Summary
Remove the exception that allowed '@' character in header names.
## Changes
- Removed the special case that allowed '@' in header names
- Updated the comment to reference RFC 9110 Section 5.1
## Why
RFC 9110 Section 5.1 states that header field names must consist only of tchar characters:
```
tchar = "!" / "#" / "$" / "%" / "&" / "'" / "*"
/ "+" / "-" / "." / "^" / "_" / "`" / "|" / "~"
/ DIGIT / ALPHA
```
'@' is not in this list, so header names containing '@' should be rejected with a 400 response.
The previous fix for INKqa09141 incorrectly allowed '@' in header names.
Fixes #12082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "mmustafasenoglu (via GitHub)" <gi...@apache.org>.
mmustafasenoglu commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4786734852
Hi @JosiahWI, thanks for asking! I think both labels make sense here. While this is a bug fix for RFC 9110 compliance, the character could indeed be used in internal headers, so marking it as Incompatible is appropriate. I've added both Bug and Incompatible labels. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "mmustafasenoglu (via GitHub)" <gi...@apache.org>.
mmustafasenoglu commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4792179606
Hi, following up on this bug fix PR. It fixes the @ character validation in header names per RFC 9110. Would appreciate a review. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4791588533
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "mmustafasenoglu (via GitHub)" <gi...@apache.org>.
mmustafasenoglu commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4783266498
Hello! This is my first contribution to Apache Traffic Server. Could you please trigger CI for this bug fix PR? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4793868046
We are actually working on this issue internally. Thank you for the contribution, but we will be posting a fix for this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #13314:
URL: https://github.com/apache/trafficserver/pull/13314#issuecomment-4784093680
@mmustafasenoglu This is a bug fix from a standards point of view, but anyone relying on the `@` character in internal headers could perceive this as a breaking change. Would you like to label it with Bug, Incompatible, or both? I expect it to be discussed by the community within a week, but I'm interested in your opinion on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: reject @ character in header names [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt closed pull request #13314: fix: reject @ character in header names
URL: https://github.com/apache/trafficserver/pull/13314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org