You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2025/02/28 04:18:34 UTC
[PR] Fix losing first page and missing time column in result set metadata [tsfile]
jt2594838 opened a new pull request, #420:
URL: https://github.com/apache/tsfile/pull/420
1. If no data is written after the first page is written, the first page will be lost.
2. The time column is missing in the ResultSetMetadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix losing first page and missing time column in result set metadata [tsfile]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #420:
URL: https://github.com/apache/tsfile/pull/420#issuecomment-2689700778
## [Codecov](https://app.codecov.io/gh/apache/tsfile/pull/420?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `60.00000%` with `18 lines` in your changes missing coverage. Please review.
> Project coverage is 65.40%. Comparing base [(`0f1ab16`)](https://app.codecov.io/gh/apache/tsfile/commit/0f1ab1683b7baa82c4539b5840414f6988f2a868?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`c4d6b51`)](https://app.codecov.io/gh/apache/tsfile/commit/c4d6b512e156fadabc9140bf93a0cae6f486dfc1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/tsfile/pull/420?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [cpp/src/cwrapper/tsfile\_cwrapper.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fcwrapper%2Ftsfile_cwrapper.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy9jd3JhcHBlci90c2ZpbGVfY3dyYXBwZXIuY2M=) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/reader/table\_result\_set.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Freader%2Ftable_result_set.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy9yZWFkZXIvdGFibGVfcmVzdWx0X3NldC5jYw==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/chunk\_writer.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Fchunk_writer.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvY2h1bmtfd3JpdGVyLmNj) | 71.42% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/time\_chunk\_writer.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Ftime_chunk_writer.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvdGltZV9jaHVua193cml0ZXIuY2M=) | 71.42% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/value\_chunk\_writer.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Fvalue_chunk_writer.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvdmFsdWVfY2h1bmtfd3JpdGVyLmNj) | 71.42% | [0 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/common/tablet.cc](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fcommon%2Ftablet.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy9jb21tb24vdGFibGV0LmNj) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/reader/result\_set.h](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Freader%2Fresult_set.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy9yZWFkZXIvcmVzdWx0X3NldC5o) | 90.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/chunk\_writer.h](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Fchunk_writer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvY2h1bmtfd3JpdGVyLmg=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/time\_chunk\_writer.h](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Ftime_chunk_writer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvdGltZV9jaHVua193cml0ZXIuaA==) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [cpp/src/writer/value\_chunk\_writer.h](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&filepath=cpp%2Fsrc%2Fwriter%2Fvalue_chunk_writer.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y3BwL3NyYy93cml0ZXIvdmFsdWVfY2h1bmtfd3JpdGVyLmg=) | 50.00% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/420?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #420 +/- ##
===========================================
- Coverage 65.40% 65.40% -0.01%
===========================================
Files 564 564
Lines 33614 33634 +20
Branches 4544 4554 +10
===========================================
+ Hits 21984 21997 +13
Misses 10995 10995
- Partials 635 642 +7
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tsfile/pull/420?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix losing first page and missing time column in result set metadata [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #420:
URL: https://github.com/apache/tsfile/pull/420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org