You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/01/12 22:44:02 UTC

[PR] Geo type changes [iceberg-rust]

rambleraptor opened a new pull request, #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Part of #1884 
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   This gets the ball rolling with parsing the Geography + Geometry types. I'd love to hear any advice you might have!
   
   ## Are these changes tested?
   
   Unit tests are included.
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4189810048

   This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "BlakeOrth (via GitHub)" <gi...@apache.org>.
BlakeOrth commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-3947814732

   hi @rambleraptor I came across this PR from the attached issue and am interested in helping this effort move forward. It looks like there are still some "todo" items in this implementation and it's not immediately clear to me if you're still working on this or are waiting on review etc.
   
   I'd be happy to give a more thorough review against the spec if that's something you're needing to push forward on this. Otherwise, is there anything I can do to help move this along?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #2019: Geo type changes
URL: https://github.com/apache/iceberg-rust/pull/2019


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4233099847

   This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "brgr-s (via GitHub)" <gi...@apache.org>.
brgr-s commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-3996290622

   @rambleraptor 
   
   I came across this PR because we wanted to implement geospatial columns for our [fork of icebeg-rust](https://github.com/lakekeeper/iceberg-rust) that we are using in Lakekeeper. We already provided a PR for partial support of the VARIANT type (https://github.com/apache/iceberg-rust/pull/2188)
   
   I made some additions to your changes because I _think_ there where Edge Interpolation Algorithms missing for the GEOGRAPHY type. Also I couldn't find the 'planar' Edge Interpolaton Algorithm, at least in the parquet spec.
   
   If you find those changes usefull you can find them here: https://github.com/brgr-s/iceberg-rust/tree/feat/geo-types-support
   
   I think the biggest obstacle is that integration tests that Spark 4.1 does not yet support geospatial types, so we can't integration test the feature at the moment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Geo type changes [iceberg-rust]

Posted by "nuts-rice (via GitHub)" <gi...@apache.org>.
nuts-rice commented on PR #2019:
URL: https://github.com/apache/iceberg-rust/pull/2019#issuecomment-4012254767

   Would you mind if I fork this to add a geo types example?
   #1826 was working on this


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org