You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by JPercivall <gi...@git.apache.org> on 2016/03/29 17:39:19 UTC
[GitHub] nifi pull request: NIFI-1662 Initial commit of adding Decimal and ...
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi/pull/310
NIFI-1662 Initial commit of adding Decimal and Math functions to EL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi NIFI-1662
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/310.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #310
----
commit e56c055ac275376dc481c437cd3640f88b3ab704
Author: jpercivall <jo...@yahoo.com>
Date: 2016-03-28T19:48:42Z
NIFI-1662 Initial commit of adding Decimal and Math functions to EL
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1662 Initial commit of adding Decimal and ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/310#issuecomment-202964957
The reason I broke out the Decimal functions for math functions is to not force users to use a specific return value.
For the logical math functions (greater than, etc.) I couldn't figure out how to parse the incoming values if they were passed in as strings. Since almost all attributes will be passed in as strings I couldn't make an assumption on whether to interpret them as longs or doubles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1662 Initial commit of adding Decimal and ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall commented on the pull request:
https://github.com/apache/nifi/pull/310#issuecomment-202971560
Forgot to fix contrib check when I made a final change and an experimental change snuck in.
This is not the PR that you are looking for.....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1662 Initial commit of adding Decimal and ...
Posted by JPercivall <gi...@git.apache.org>.
Github user JPercivall closed the pull request at:
https://github.com/apache/nifi/pull/310
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---