You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jiangjie Qin <be...@gmail.com> on 2014/11/14 17:57:05 UTC
Review Request 28040: Patch for KAFKA-1770
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28040/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1770
https://issues.apache.org/jira/browse/KAFKA-1770
Repository: kafka
Description
-------
Modified doc for UnknownTopicOrPartitionException
Diffs
-----
core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala 781e551e5b78b5f436431575c2961fe15acd1414
Diff: https://reviews.apache.org/r/28040/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 28040: Patch for KAFKA-1770
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28040/#review61751
-----------------------------------------------------------
UnknownTopicOrPartitionException can be thrown either at the producer side when the cached metadata does not have the info for this partitionId, or thrown at the server side when the specified partition does not exist on the broker. So how about:
Indicates one of the following situation:
1. Producer does not have the know the partition metadata for this id upon sending messages
2. Broker does not have the specified partition by id upon receiving messages
core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala
<https://reviews.apache.org/r/28040/#comment103633>
remove " (and the end " on line 23)
- Guozhang Wang
On Nov. 14, 2014, 4:57 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28040/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2014, 4:57 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1770
> https://issues.apache.org/jira/browse/KAFKA-1770
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Modified doc for UnknownTopicOrPartitionException
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala 781e551e5b78b5f436431575c2961fe15acd1414
>
> Diff: https://reviews.apache.org/r/28040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 28040: Patch for KAFKA-1770
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28040/#review62665
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On Nov. 20, 2014, 12:37 a.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28040/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 12:37 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1770
> https://issues.apache.org/jira/browse/KAFKA-1770
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's comments
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala 781e551e5b78b5f436431575c2961fe15acd1414
>
> Diff: https://reviews.apache.org/r/28040/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 28040: Patch for KAFKA-1770
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28040/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 12:37 a.m.)
Review request for kafka.
Bugs: KAFKA-1770
https://issues.apache.org/jira/browse/KAFKA-1770
Repository: kafka
Description (updated)
-------
Addressed Guozhang's comments
Diffs (updated)
-----
core/src/main/scala/kafka/common/UnknownTopicOrPartitionException.scala 781e551e5b78b5f436431575c2961fe15acd1414
Diff: https://reviews.apache.org/r/28040/diff/
Testing
-------
Thanks,
Jiangjie Qin