[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7542: Add IN function

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7542:
URL: https://github.com/apache/pinot/pull/7542#discussion_r724598767



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import com.google.common.base.Preconditions;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.TransformFunctionType;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.apache.pinot.spi.utils.ByteArray;
+
+
+/**
+ * The IN transform function takes more than 1 arguments:
+ * <ul>
+ *   <li>Expression: a single-value expression</li>
+ *   <li>values: a set of literal strings</li>
+ * </ul>
+ * <p>For each docId, the function returns {@code 1} if the set of values contains the value of the expression,
+ * {code 0} if not.
+ * <p>E.g. {@code SELECT col IN ('a','b','c') FROM myTable)}
+ */
+public class InTransformFunction extends BaseTransformFunction {
+  private TransformFunction _transformFunction;
+  private TransformFunction[] _valueTransformFunctions;
+  private int[] _results;
+
+  @Override
+  public String getName() {
+    return TransformFunctionType.IN.getName();
+  }
+
+  @Override
+  public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) {
+    Preconditions.checkArgument(arguments.size() >= 2,
+        "at least 2 arguments are required for IN transform function: expression, values");
+    Preconditions.checkArgument(arguments.get(0).getResultMetadata().isSingleValue(),
+        "First argument for IN transform function must be a single-value expression");

Review comment:
       We should consider supporting MV as well (any value matches the IN values are count as match)

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import com.google.common.base.Preconditions;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.TransformFunctionType;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.apache.pinot.spi.utils.ByteArray;
+
+
+/**
+ * The IN transform function takes more than 1 arguments:
+ * <ul>
+ *   <li>Expression: a single-value expression</li>
+ *   <li>values: a set of literal strings</li>
+ * </ul>
+ * <p>For each docId, the function returns {@code 1} if the set of values contains the value of the expression,
+ * {code 0} if not.
+ * <p>E.g. {@code SELECT col IN ('a','b','c') FROM myTable)}
+ */
+public class InTransformFunction extends BaseTransformFunction {
+  private TransformFunction _transformFunction;
+  private TransformFunction[] _valueTransformFunctions;
+  private int[] _results;
+
+  @Override
+  public String getName() {
+    return TransformFunctionType.IN.getName();
+  }
+
+  @Override
+  public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) {
+    Preconditions.checkArgument(arguments.size() >= 2,

Review comment:
       (nit) cache `arguments.size()` into a local variable

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import com.google.common.base.Preconditions;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.TransformFunctionType;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.apache.pinot.spi.utils.ByteArray;
+
+
+/**
+ * The IN transform function takes more than 1 arguments:
+ * <ul>
+ *   <li>Expression: a single-value expression</li>
+ *   <li>values: a set of literal strings</li>
+ * </ul>
+ * <p>For each docId, the function returns {@code 1} if the set of values contains the value of the expression,
+ * {code 0} if not.
+ * <p>E.g. {@code SELECT col IN ('a','b','c') FROM myTable)}
+ */
+public class InTransformFunction extends BaseTransformFunction {
+  private TransformFunction _transformFunction;
+  private TransformFunction[] _valueTransformFunctions;
+  private int[] _results;
+
+  @Override
+  public String getName() {
+    return TransformFunctionType.IN.getName();
+  }
+
+  @Override
+  public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) {
+    Preconditions.checkArgument(arguments.size() >= 2,
+        "at least 2 arguments are required for IN transform function: expression, values");
+    Preconditions.checkArgument(arguments.get(0).getResultMetadata().isSingleValue(),
+        "First argument for IN transform function must be a single-value expression");
+    _transformFunction = arguments.get(0);
+    _valueTransformFunctions = new TransformFunction[arguments.size() - 1];
+    for (int i = 1; i < arguments.size(); i++) {
+      Preconditions.checkArgument(arguments.get(i).getResultMetadata().isSingleValue(),
+          "The values argument for IN transform function must be single value");
+      _valueTransformFunctions[i - 1] = arguments.get(i);
+    }
+  }
+
+  @Override
+  public TransformResultMetadata getResultMetadata() {
+    return BOOLEAN_SV_NO_DICTIONARY_METADATA;
+  }
+
+  @Override
+  public int[] transformToIntValuesSV(ProjectionBlock projectionBlock) {
+    if (_results == null) {
+      _results = new int[DocIdSetPlanNode.MAX_DOC_PER_CALL];
+    }
+
+    int length = projectionBlock.getNumDocs();
+    FieldSpec.DataType storedType = _transformFunction.getResultMetadata().getDataType().getStoredType();
+    switch (storedType) {
+      case INT:
+        int[] intValues = _transformFunction.transformToIntValuesSV(projectionBlock);
+        int[][] inIntValues = new int[_valueTransformFunctions.length][];

Review comment:
       We should pre-process the IN values in the `init()` as mentioned above instead of doing per-block per-value match

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import com.google.common.base.Preconditions;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.TransformFunctionType;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.apache.pinot.spi.utils.ByteArray;
+
+
+/**
+ * The IN transform function takes more than 1 arguments:
+ * <ul>
+ *   <li>Expression: a single-value expression</li>
+ *   <li>values: a set of literal strings</li>
+ * </ul>
+ * <p>For each docId, the function returns {@code 1} if the set of values contains the value of the expression,
+ * {code 0} if not.
+ * <p>E.g. {@code SELECT col IN ('a','b','c') FROM myTable)}
+ */
+public class InTransformFunction extends BaseTransformFunction {
+  private TransformFunction _transformFunction;
+  private TransformFunction[] _valueTransformFunctions;
+  private int[] _results;

Review comment:
       You may directly use the `_intValuesSV` from the `BaseTransformFunction` without creating another member variable

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TransformFunctionFactory.java
##########
@@ -94,6 +94,7 @@ private TransformFunctionFactory() {
           put(canonicalize(TransformFunctionType.DATETRUNC.getName().toLowerCase()), DateTruncTransformFunction.class);
           put(canonicalize(TransformFunctionType.ARRAYLENGTH.getName().toLowerCase()),
               ArrayLengthTransformFunction.class);
+          put(canonicalize(TransformFunctionType.IN.getName().toLowerCase()), InTransformFunction.class);

Review comment:
       (nit) Put it below the `LESS_THAN_OR_EQUAL` since they are of the same category and return BOOLEAN values?

##########
File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java
##########
@@ -0,0 +1,161 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.operator.transform.function;
+
+import com.google.common.base.Preconditions;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.function.TransformFunctionType;
+import org.apache.pinot.core.operator.blocks.ProjectionBlock;
+import org.apache.pinot.core.operator.transform.TransformResultMetadata;
+import org.apache.pinot.core.plan.DocIdSetPlanNode;
+import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.data.FieldSpec;
+import org.apache.pinot.spi.utils.ByteArray;
+
+
+/**
+ * The IN transform function takes more than 1 arguments:
+ * <ul>
+ *   <li>Expression: a single-value expression</li>
+ *   <li>values: a set of literal strings</li>
+ * </ul>
+ * <p>For each docId, the function returns {@code 1} if the set of values contains the value of the expression,
+ * {code 0} if not.
+ * <p>E.g. {@code SELECT col IN ('a','b','c') FROM myTable)}
+ */
+public class InTransformFunction extends BaseTransformFunction {
+  private TransformFunction _transformFunction;
+  private TransformFunction[] _valueTransformFunctions;
+  private int[] _results;
+
+  @Override
+  public String getName() {
+    return TransformFunctionType.IN.getName();
+  }
+
+  @Override
+  public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) {
+    Preconditions.checkArgument(arguments.size() >= 2,
+        "at least 2 arguments are required for IN transform function: expression, values");
+    Preconditions.checkArgument(arguments.get(0).getResultMetadata().isSingleValue(),
+        "First argument for IN transform function must be a single-value expression");
+    _transformFunction = arguments.get(0);
+    _valueTransformFunctions = new TransformFunction[arguments.size() - 1];

Review comment:
       The values here should always be `LiteralTransformFunction`. We can construct a IN value set here based on the main function data type. The IN value can be read via `LiteralTransformFunction.getLiteral()`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org