[jira] [Comment Edited] (HBASE-21721) reduce write#syncs() times

["Bo Cui (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17165159#comment-17165159 ] 

Bo Cui edited comment on HBASE-21721 at 7/26/20, 4:46 AM:
----------------------------------------------------------

# yes, AsyncFsWAL is not in the 1.3 and older hbase
 # in 2.x version, default is async WAL, but FSHLog exists
 # the patch does not apply with AsyncFSWAL


was (Author: bo cui):
# yes, AsyncFsWAL is not in the 1.3 and older hbase
 # in 2.x version, default is async WAL, but FSWAL exists
 # the patch does not apply with AsyncFSWAL

> reduce write#syncs() times
> --------------------------
>
>                 Key: HBASE-21721
>                 URL: https://issues.apache.org/jira/browse/HBASE-21721
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.3.1, 2.1.1, master, 2.2.3
>            Reporter: Bo Cui
>            Priority: Major
>
> the number of write#syncs can be reduced by updating the highestUnsyncedSequence：
> before write#sync(), get the current highestUnsyncedSequence 
> after write#sync, highestSyncedSequence=highestUnsyncedSequence
>  
> {code:title=FSHLog.java|borderStyle=solid}
> // Some comments here
> public void run()
> {
>     long currentSequence;
>       while (!isInterrupted()) {
>         int syncCount = 0;
>         try {
>           while (true) {
>             ...
>           try {
>             Trace.addTimelineAnnotation("syncing writer");
>             long unSyncedFlushSeq = highestUnsyncedSequence;
>             writer.sync();
>             Trace.addTimelineAnnotation("writer synced");
>             if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;
>             currentSequence = updateHighestSyncedSequence(currentSequence);
>           } catch (IOException e) {
>             LOG.error("Error syncing, request close of WAL", e);
>             lastException = e;
>           } catch (Exception e) {
>            ...
>     }
> }
> {code}
> Add code
>  long unSyncedFlushSeq = highestUnsyncedSequence;
>  if( unSyncedFlushSeq > currentSequence ) currentSequence = unSyncedFlushSeq;



--
This message was sent by Atlassian Jira
(v8.3.4#803005)