You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by sh...@apache.org on 2013/07/18 14:47:57 UTC

mac commit: [CB-4277] Revert deleting of support

Updated Branches:
  refs/heads/master 1922919de -> b100f97ec


[CB-4277] Revert deleting of <param name="onload" value="true" /> support


Project: http://git-wip-us.apache.org/repos/asf/cordova-osx/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-osx/commit/b100f97e
Tree: http://git-wip-us.apache.org/repos/asf/cordova-osx/tree/b100f97e
Diff: http://git-wip-us.apache.org/repos/asf/cordova-osx/diff/b100f97e

Branch: refs/heads/master
Commit: b100f97ecbee85394f35ffa3a965c01af98ba8cf
Parents: 1922919
Author: Shazron Abdullah <sh...@apache.org>
Authored: Thu Jul 18 05:47:47 2013 -0700
Committer: Shazron Abdullah <sh...@apache.org>
Committed: Thu Jul 18 05:47:47 2013 -0700

----------------------------------------------------------------------
 .../CordovaFramework/Classes/Commands/CDVConfigParser.m         | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-osx/blob/b100f97e/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
----------------------------------------------------------------------
diff --git a/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m b/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
index 5d32753..ba71066 100644
--- a/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
+++ b/CordovaFramework/CordovaFramework/Classes/Commands/CDVConfigParser.m
@@ -79,8 +79,9 @@
         if ([paramName isEqualToString:@"ios-package"]) {
             pluginsDict[featureName] = value;
         }
-        NSString* onload = [attributeDict[@"onload"] lowercaseString];
-        if ([@"true" isEqualToString : onload]) {
+        BOOL paramIsOnload = ([paramName isEqualToString:@"onload"] && [@"true" isEqualToString : value]);
+        BOOL attribIsOnload = [@"true" isEqualToString : [attributeDict[@"onload"] lowercaseString]];
+        if (paramIsOnload || attribIsOnload) {
             [self.startupPluginNames addObject:featureName];
         }
     } else if ([elementName isEqualToString:@"access"]) {