You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "john-bodley (via GitHub)" <gi...@apache.org> on 2023/07/08 04:20:56 UTC
[GitHub] [superset] john-bodley opened a new pull request, #24629: chore: Drop rouge tables
john-bodley opened a new pull request, #24629:
URL: https://github.com/apache/superset/pull/24629
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Looking at the current schema,
```
$ rm superset.db
$ FLASK_DEBUG=true superset db upgrade
$ sqlite3 superset.db
sqlite> .tables
ab_permission metrics
ab_permission_view query
ab_permission_view_role report_execution_log
ab_register_user report_recipient
ab_role report_schedule
ab_user report_schedule_user
ab_user_role rls_filter_roles
ab_view_menu rls_filter_tables
alembic_version row_level_security_filters
alert_logs saved_query
alert_owner sl_columns
alerts sl_dataset_columns
annotation sl_dataset_tables
annotation_layer sl_dataset_users
cache_keys sl_datasets
clusters sl_table_columns
columns sl_tables
css_templates slice_email_schedules
dashboard_email_schedules slice_user
dashboard_roles slices
dashboard_slices sql_metrics
dashboard_user sql_observations
dashboards sqlatable_user
datasources ssh_tunnels
dbs tab_state
druiddatasource_user table_columns
dynamic_plugin table_schema
embedded_dashboards tables
favstar tag
filter_sets tagged_object
key_value url
keyvalue user_attribute
logs
sqlite>
```
it became apparent that there were a number of rouge tables—those which technically were likely dropped in other migrations—but seem to remain in the database. I speculate maybe these were accidentally skipped when resolving a diamond dependency.
This PR adds a migration to drop these tables. Note that the downgrade is a no-op as there's no reference to the underlying schemas in the code pre-migration. I'm made sure the migration is atomic by first checking that the table exists prior to it being dropped.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
CI.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [x] Migration is atomic, supports rollback & is backwards-compatible
- [x] Confirm DB migration upgrade and downgrade tested
- [x] Runtime estimates and downtime expectations provided: < 5 seconds
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24629: chore: Drop rouge tables
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24629:
URL: https://github.com/apache/superset/pull/24629#issuecomment-1626864006
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24629?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24629](https://app.codecov.io/gh/apache/superset/pull/24629?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4a782eb) into [master](https://app.codecov.io/gh/apache/superset/commit/c53b2499988b5aeec96b1064f86703a3891e0efc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c53b249) will **decrease** coverage by `10.65%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4a782eb differs from pull request most recent head 968624c. Consider uploading reports for the commit 968624c to get more accurate results
```diff
@@ Coverage Diff @@
## master #24629 +/- ##
===========================================
- Coverage 68.97% 58.33% -10.65%
===========================================
Files 1907 1907
Lines 74153 74153
Branches 8182 8182
===========================================
- Hits 51148 43255 -7893
- Misses 20882 28775 +7893
Partials 2123 2123
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `54.14% <ø> (?)` | |
| postgres | `?` | |
| presto | `54.04% <ø> (ø)` | |
| python | `61.12% <ø> (-22.20%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.83% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 299 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24629/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley merged pull request #24629: chore: Drop rouge constraints and tables
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley merged PR #24629:
URL: https://github.com/apache/superset/pull/24629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org