You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/08/10 09:14:22 UTC

[GitHub] [kylin] zhengshengjun commented on a change in pull request #1722: KYLIN-4903 cache parent datasource to accelerate next layer's cuboid building

zhengshengjun commented on a change in pull request #1722:
URL: https://github.com/apache/kylin/pull/1722#discussion_r685841380



##########
File path: kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/job/CubeBuildJob.java
##########
@@ -329,7 +329,7 @@ private void build(Collection<NBuildSourceInfo> buildSourceInfos, SegmentInfo se
             Preconditions.checkState(!toBuildCuboids.isEmpty(), "To be built cuboids is empty.");
             Dataset<Row> parentDS = info.getParentDS();
 
-            if (toBuildCuboids.size() > 1) {
+            if (toBuildCuboids.size() >= 1) {

Review comment:
       good suggestion ~




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org