You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/04/29 12:30:14 UTC

[GitHub] [avro] RyanSkraba commented on pull request #869: AVRO-2822: Add toString that doesn't inline referenced schemas

RyanSkraba commented on pull request #869:
URL: https://github.com/apache/avro/pull/869#issuecomment-621171717


   Hello and thanks for the contribution!  I've got no problem with adding another toString(...) method for 1.10.x, but I like the idea of the Formatter for a long-term solution.  I added to the JIRA:
   
   > I think we should probably get away from using toString(...) to generate JSON.  It's probably time to add a configurable Formatter (like we replaced .parse(...) with a configurable Parser a while ago.)
   
   Is this too much to do for 1.10.x ?  I can create a new JIRA if we want to do this in a later release.
   
   Just to clarify: the goal here is to avoid writing out some nested schemas again, and to refer to them by name?  In that case, we would expect parsing this schema string would fail when using a brand-new parser, right?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org