You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/13 16:01:00 UTC

[jira] [Commented] (CB-12838) Order of plugins in config.xml modified during build

    [ https://issues.apache.org/jira/browse/CB-12838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085912#comment-16085912 ] 

ASF GitHub Bot commented on CB-12838:
-------------------------------------

GitHub user audreyso opened a pull request:

    https://github.com/apache/cordova-lib/pull/574

    CB-12838 : prevented sorting and alphabetizing platforms and plugins i…

    …n pkgJson and config
    
    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### Platforms affected
    
    
    ### What does this PR do?
    
    Prevents modifying/alphabetizing platforms and plugins in config
    
    ### What testing has been done on this change?
    
    
    ### Checklist
    - [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/audreyso/cordova-lib CB-12838

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #574
    
----
commit 083deef9ce70afe8455a36f49ddccf0b093558f8
Author: Audrey So <au...@apache.org>
Date:   2017-07-12T00:21:41Z

    CB-12838 : prevented sorting and aphabetizing platforms and plugins in pkgjson and config

----


> Order of plugins in config.xml modified during build
> ----------------------------------------------------
>
>                 Key: CB-12838
>                 URL: https://issues.apache.org/jira/browse/CB-12838
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: cordova-cli
>    Affects Versions: cordova@7.0.0
>         Environment: Mac OS 10.12.4, Cordova 7.0.1
>            Reporter: Anton Weber
>            Priority: Minor
>              Labels: android, cordova-8.0.0, ios, reproduced, triaged
>
> Running cordova build android or cordova build ios changes the order in which plugins are listed in the config.xml (arranging them alphabetically). 
> This causes problems when manually resolving dependencies, e.g. when installing a specific version of a dependency first by having it higher up in the list.
> Example:
> Original config.xml content:
> ...
>     <plugin name="cordova-plugin-device" spec="^1.1.6" />
>     <plugin name="cordova-plugin-camera" spec="^2.4.1" />
>     <plugin name="cordova-plugin-whitelist" spec="^1.3.2" />
>     <engine name="android" spec="^6.2.3" />
>     <engine name="ios" spec="^4.4.0" />
> ...
> After cordova build:
> ...
>     <engine name="android" spec="^6.2.3" />
>     <engine name="ios" spec="^4.4.0" />
>     <plugin name="cordova-plugin-camera" spec="^2.4.1" />
>     <plugin name="cordova-plugin-device" spec="^1.1.6" />
>     <plugin name="cordova-plugin-whitelist" spec="^1.3.2" />
> ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org