[GitHub] [kafka-site] divijvaidya commented on a diff in pull request #421: KAFKA-13868: Add new item 'Apache Software' in top nav bar including privacy policy

[GitBox <gi...@apache.org>]

divijvaidya commented on code in PR #421:
URL: https://github.com/apache/kafka-site/pull/421#discussion_r923468457


##########
includes/_top.htm:
##########
@@ -150,6 +150,48 @@
 							</li>
 						</ul>
 					</li>
+					<li class="top-nav-item" role="menuitem">
+						<a href="#" class="top-nav-item-anchor" aria-haspopup="true" aria-expanded="false" aria-controls="nav-community-menu">
+							Apache Software
+						</a>
+						<ul class="top-nav-menu" aria-hidden="true" role="menu" id="nav-community-menu" title="Apache Homepage">
+							<li class="top-nav-menu-item" role="menuitem">
+								<a class="top-nav-anchor" tabindex="-1" href="https://www.apache.org/" target="_blank">
+									Apache Homepage

Review Comment:
   That is fair.
   
   Just to re-iterate so that we are on the same page, we want to remove the "Apache Software" section from the nav bar and instead add it to the footer of the homepage towards the bottom. That section will contain the necessary hyperlinks that are required by ASF. 
   
   I am a bit rusty with my front-end skills but let me try to see what I can do here :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org