You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/11/24 10:14:05 UTC

[GitHub] [hbase] ramkrish86 commented on a change in pull request #2675: HBASE-25277 postScannerFilterRow impacts Scan performance a lot in HBase 2.x

ramkrish86 commented on a change in pull request #2675:
URL: https://github.com/apache/hbase/pull/2675#discussion_r529401094



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
##########
@@ -1848,13 +1848,6 @@ public void postScannerClose(final ObserverContext<RegionCoprocessorEnvironment>
     scannerOwners.remove(s);
   }
 
-  @Override
-  public boolean postScannerFilterRow(final ObserverContext<RegionCoprocessorEnvironment> e,
-      final InternalScanner s, final Cell curRowCell, final boolean hasMore) throws IOException {
-    // 'default' in RegionObserver might do unnecessary copy for Off heap backed Cells.

Review comment:
       Actually in RegionObserver we don't do any copy so this comment was irrelevant. So it is ok to remove the default impl in the security CP that we have with hbase.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org