You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/26 05:16:52 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete
rusackas opened a new pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The `remove, and add chart flow` test seems to flake out fairly often, and I've seen it do so with errors saying that pointer-events were disabled by a parent's CSS, and that the element was still animating. I'm assuming that all of this is due to the animation and such that takes place when switching tabs. Here's hoping 1s of waiting will properly cover that issue.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Keep an eye on CI!
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074#issuecomment-699511488
The help link for this error is [here](https://docs.cypress.io/guides/references/error-messages.html#cy-failed-because-the-element-is-currently-animating); it sounds like we're one of the "edge cases" they discuss, where the test is trying to interact with the element before it's finished animating.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074#issuecomment-699585251
Wow, everyday I learn something new about Cypress. Thanks for the explanation! This sounds like a good theory. Let's hope it really does fix it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #11074: fix: Adding timeout to flaky cypress test, to wait for animation to complete
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #11074:
URL: https://github.com/apache/incubator-superset/pull/11074#issuecomment-699510697
> The way Cypress `get` works is to constantly retry querying the DOM until the elements that match the selector are found or timeout. https://docs.cypress.io/guides/core-concepts/retry-ability.html
>
> So waiting arbitrary duration wouldn't really help with test flakiness. In fact, there is an ESLint rule to discourage that: https://docs.cypress.io/guides/references/best-practices.html
The problem seems to be though that it IS finding an element that matches the selector, but that element is not yet in a state where it's completely visible (animating) or clickable (with `pointer-events:none` applied to it). It _seems_ like it's just not waiting for that transition to finish before starting the `drag` step of the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org