[GitHub] nifi pull request #2732: NIFI-5225: Purge event data from event repository w...

[FrederikP <gi...@git.apache.org>]

GitHub user FrederikP opened a pull request:

    https://github.com/apache/nifi/pull/2732

    NIFI-5225: Purge event data from event repository when Connectable is removed

    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    _Clean install ran through just fine, but contrib-check complained about an unrelated package_
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] ~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~ 
    - [ ] ~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~
    - [ ] ~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~
    - [ ] ~~If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?~~
    
    ### For documentation related changes:
    - ~~[ ] Have you ensured that format looks appropriate for the output in which it is rendered?~~
    
    I introduced the option to purge data from the FlowFileEventRepository (the 5 min ring buffer) to fix this:
    https://issues.apache.org/jira/browse/NIFI-5225
    
    And it works for our setup.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FrederikP/nifi master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2732.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2732
    
----
commit 4e5a118305c9513cca239c136c48239c501e9907
Author: Frederik Petersen <fp...@...>
Date:   2018-05-22T10:55:59Z

    NIFI-5225: Purge event data from event repository when Connectable is removed

----


---

[GitHub] nifi pull request #2732: NIFI-5225: Purge event data from event repository w...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2732


---

[GitHub] nifi issue #2732: NIFI-5225: Purge event data from event repository when Con...

[markap14 <gi...@git.apache.org>]

Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/2732
  
    @FrederikP  all looks good here. I have merged the changes to master. Thanks for the fix!


---