You are viewing a plain text version of this content. The canonical link for it is here.
Posted to droids-dev@incubator.apache.org by "Eugen Paraschiv (JIRA)" <ji...@apache.org> on 2011/02/23 20:32:38 UTC
[jira] Created: (DROIDS-130) Use explicit versions for the Maven
dependencies
Use explicit versions for the Maven dependencies
------------------------------------------------
Key: DROIDS-130
URL: https://issues.apache.org/jira/browse/DROIDS-130
Project: Droids
Issue Type: Improvement
Affects Versions: 0.0.2
Reporter: Eugen Paraschiv
Fix For: 0.0.2
It's best practice to define the Maven dependencies (and plugins) by defining explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005869#comment-13005869 ]
Eugen Paraschiv commented on DROIDS-130:
----------------------------------------
About the default pom provided by Apache, I think there is certainly an advantage of having a simpler pom, but there are also some disadvantages.
For one, Maven 3 is still very new, and plugins are being worked on and fixed with every new release. Not defining our own versions takes away that advantage.
Second, the upgrade from this version of the Apache pom and the next is going to represent a leap instead of an incremental improvement, which is not something to be desired. The pom probably recognizes this, as it says: "Standard versions of plugins are also defined, these may be overridden by individual projects as well."
Then, with Droids being a relatively small project, the advantage of not having a few version lines in the pom isn't really that big.
The decision is likely going to be a balance between advantages and disadvantages.
In any event, I will first provide a new small(er) patch addressing the plugins that do not have versions in our pom and also do not exist in the Apache pom.
Thanks.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (DROIDS-130) Use explicit versions
for the Maven plugins
Posted by "Tobias Rübner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056526#comment-13056526 ]
Tobias Rübner edited comment on DROIDS-130 at 6/28/11 2:16 PM:
---------------------------------------------------------------
This patch is broken!
I think it has something to do with the module reorganisation [DROIDS-107|https://issues.apache.org/jira/browse/DROIDS-107]
was (Author: tobr):
This path is broken!
I think it has something to do with the module reorganisation [DROIDS-107|https://issues.apache.org/jira/browse/DROIDS-107]
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated DROIDS-130:
----------------------------------
Remaining Estimate: 0h
Original Estimate: 0h
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007692#comment-13007692 ]
Eugen Paraschiv commented on DROIDS-130:
----------------------------------------
OK, makes sense. I'll submit the patch to only contain versions for plugins that don't have any and also are not specified in the parent pom.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003875#comment-13003875 ]
Bertil Chapuis commented on DROIDS-130:
---------------------------------------
We inherit from http://repo1.maven.org/maven2/org/apache/apache/9/apache-9.pom. Since this file will not change, we should probably keep the plugin versions proposed here and simplify our pom files as much as possible. We may also use plugin management to add consistency to our configuration. What do you think?
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007398#comment-13007398 ]
Bertil Chapuis commented on DROIDS-130:
---------------------------------------
Note I encourage specifying the version for the plugins which are not inherited from the apache pom.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-130:
-----------------------------------
Description: It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central. (was: It's best practice to define the Maven dependencies (and plugins) by defining explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central. )
Summary: Use explicit versions for the Maven plugins (was: Use explicit versions for the Maven dependencies)
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Richard Frovarp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004023#comment-13004023 ]
Richard Frovarp commented on DROIDS-130:
----------------------------------------
Sounds good.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertil Chapuis updated DROIDS-130:
----------------------------------
Attachment: DROIDS-130_v2.patch
It doesn't really go in the direction of the initial patch. The aim was to define the plugin versions only when they are not present in the inherited apache pom project.
The patch also removes the maven-eclipse-plugin definition since the behaviour defined in the pom can be obtained from the command line: mvn eclipse:eclipse -DdownloadSources=true -DdownloadJavadocs=true
I also moved the versions from the properties section to the plugin or dependencies definitions and made some formatting changes.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Richard Frovarp (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Richard Frovarp resolved DROIDS-130.
------------------------------------
Resolution: Fixed
This appears to be fixed in trunk.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Tobias Rübner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056526#comment-13056526 ]
Tobias Rübner commented on DROIDS-130:
--------------------------------------
This path is broken!
I think it has something to do with the module reorganisation [DROIDS-107|https://issues.apache.org/jira/browse/DROIDS-107]
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugen Paraschiv updated DROIDS-130:
-----------------------------------
Attachment: DROIDS-130_v1.patch
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056530#comment-13056530 ]
Eugen Paraschiv commented on DROIDS-130:
----------------------------------------
Some time has passed since this patch was generated. I will resolve the conflicts and regenerate it as soon as possible.
Thanks for making me aware of the problem.
Eugen.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Eugen Paraschiv (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005851#comment-13005851 ]
Eugen Paraschiv commented on DROIDS-130:
----------------------------------------
Unfortunately I have some conflicts when trying to apply the provided patch.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (DROIDS-130) Use explicit versions for the Maven
plugins
Posted by "Bertil Chapuis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DROIDS-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007397#comment-13007397 ]
Bertil Chapuis commented on DROIDS-130:
---------------------------------------
Sorry for the patch. This one should work. I totally agree with you about the versions of the dependencies (DROIDS-134). However for the plugins I don't really see the problem. I upgraded the trunk from the version 7 to the version 9 of the apache pom something like three weeks ago and I think nobody noticed the change. If a problem is encountered, since droids is a small project, it will be easy to solve it.
> Use explicit versions for the Maven plugins
> -------------------------------------------
>
> Key: DROIDS-130
> URL: https://issues.apache.org/jira/browse/DROIDS-130
> Project: Droids
> Issue Type: Improvement
> Affects Versions: 0.0.2
> Reporter: Eugen Paraschiv
> Fix For: 0.0.2
>
> Attachments: DROIDS-130_v1.patch, DROIDS-130_v2.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> It's best practice to define the Maven plugins by using explicit versions. This improves the repeatability of the build, as it doesn't depend on the releases of new versions of these dependencies to Maven central.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira