[jira] [Updated] (ISIS-894) Remove @NotPersistable annotation and corresponding facet

["Daniel Keir Haywood (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ISIS-894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Keir Haywood updated ISIS-894:
-------------------------------------
    Fix Version/s:     (was: 2.2.0)
                   2.0.0-M3

> Remove @NotPersistable annotation and corresponding facet
> ---------------------------------------------------------
>
>                 Key: ISIS-894
>                 URL: https://issues.apache.org/jira/browse/ISIS-894
>             Project: Isis
>          Issue Type: Improvement
>          Components: Isis Core
>    Affects Versions: core-1.6.0
>            Reporter: Daniel Keir Haywood
>            Priority: Minor
>             Fix For: 2.0.0-M3
>
>
> This annotation is a no-op (tested in Wicket and Restful Objects) and should be removed from the applib
> ... perhaps.  Looking again at the code, there's a check in PersistenceSession#makePersistent() and throws exception if attempt to explicitly persist.
> However, JDO might persist anyway due to persistence-by-reachability, so the check would need to be added to the appropriate JDO lifecycle callback.
> As I think all the above is marginal benefit, think we should just remove in 2.0.0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)