You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/11/15 22:33:24 UTC
[GitHub] [helix] alirezazamani commented on a change in pull request #589:
Add CloudConfig operations
alirezazamani commented on a change in pull request #589: Add CloudConfig operations
URL: https://github.com/apache/helix/pull/589#discussion_r347037997
##########
File path: helix-core/src/test/java/org/apache/helix/model/cloud/TestCloudConfig.java
##########
@@ -0,0 +1,61 @@
+package org.apache.helix.model.cloud;
Review comment:
I would say let's keep them separated because this config is newly introduced and it is easier to maintain it later. Perhaps we will add more test to this Tests later to this file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org