You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2026/06/22 21:42:10 UTC

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24499


Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................

IMPALA-14760: Add Clang 12 for compilation

Impala's dependency on LLVM is very performance sensitive,
but we also use Clang for sanitizer builds. In that context,
our old version of Clang has been causing issues compiling
new dependencies (e.g. IMPALA-13190 for roaring bitmap,
IMPALA-14092 for Paimon's use of Arrow). This adds a build
of LLVM 12 to provide a newer Clang for our sanitizer
builds. This includes LLD in the build, which may be useful
as an alternative linker.

This does a lot of changes to the structure of the LLVM
build scripts. It adds an ability to build with PGO (which
is not used for this change). It also changes the LLVM
build to use ninja to limit link concurrency.

Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
---
M buildall.sh
A source/llvm/build-helper.sh
D source/llvm/build-source-tarball.sh
M source/llvm/build.sh
4 files changed, 617 insertions(+), 212 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/99/24499/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 3: Code-Review+1

Rebased this patch, carrying +1


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 16:47:57 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 Jul 2026 18:21:24 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 2: Verified+1

I verified The complete commit stack on private infrastructure. Builds passed for Intel and ARM64 architectures both.


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sun, 26 Jul 2026 21:46:43 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................

IMPALA-14760: Add Clang 12 for compilation

Impala's dependency on LLVM is very performance sensitive,
but we also use Clang for sanitizer builds. In that context,
our old version of Clang has been causing issues compiling
new dependencies (e.g. IMPALA-13190 for roaring bitmap,
IMPALA-14092 for Paimon's use of Arrow). This adds a build
of LLVM 12 to provide a newer Clang for our sanitizer
builds. This includes LLD in the build, which may be useful
as an alternative linker.

This does a lot of changes to the structure of the LLVM
build scripts. It adds an ability to build with PGO (which
is not used for this change). It also changes the LLVM
build to use ninja to limit link concurrency.

Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Reviewed-on: http://gerrit.cloudera.org:8080/24499
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
---
M buildall.sh
A source/llvm/build-helper.sh
D source/llvm/build-source-tarball.sh
M source/llvm/build.sh
4 files changed, 617 insertions(+), 212 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, but someone else must approve; Verified
  Laszlo Gaal: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jul 2026 21:32:53 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 19:52:54 +0000
Gerrit-HasComments: No

[native-toolchain-CR] IMPALA-14760: Add Clang 12 for compilation

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24499 )

Change subject: IMPALA-14760: Add Clang 12 for compilation
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iabd1ac45c4c3e28bc35288129b74fa754956a266
Gerrit-Change-Number: 24499
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Aug 2026 23:36:25 +0000
Gerrit-HasComments: No