[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on pull request #14: [MBUILDCACHE-20] Use local cache before remote cache by default

[GitBox <gi...@apache.org>]

AlexanderAshitkin commented on PR #14:
URL: https://github.com/apache/maven-build-cache-extension/pull/14#issuecomment-1128838217

   > > > @maximilian-novikov @maximilian-novikov-db could you have a look at this one ? I don't really understand why the remote cache would have to be checked before the local one...
   > 
   > > 
   > 
   > > that's the good question, probably that's the legacy logic, which doesn't make sense after @AlexanderAshitkin added 'proper' plugins input reconciliation
   > 
   > > 
   > 
   > > i would just fix this, without introducing a new flag
   > 
   > 
   > 
   > Ok, I'll simplify the PR then.
   
   Hi
   The idea was to use the same artifact across all the cache consumers. By looking in the remote first it's possible to avoid using locally built artifacts and cached binaries should become eventually consistent across all nodes, even if remote cache was overridden. I cannot recall other implications except that, but discrepancies theoretically possible if binaries compared directly(snapshots?). But definitely local first lookup will work in majority of cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org