You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/06/23 21:01:27 UTC
[kudu-CR] Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
Hello Jean-Daniel Cryans, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7280
to review the following change.
Change subject: Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
......................................................................
Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
With the proper fix for KUDU-2052 ready, we no longer need this workaround.
This reverts commit 93798ef7eb226f025b86b227bc8f7fe27cc22716.
Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_fs.cc
3 files changed, 1 insertion(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/7280/1
--
To view, visit http://gerrit.cloudera.org:8080/7280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7280
to look at the new patch set (#3).
Change subject: Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
......................................................................
Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
With the proper fix for KUDU-2052 ready, we no longer need this workaround.
This reverts commit 410763afa61252fa8c7125f66429bad602db795a.
Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_fs.cc
3 files changed, 1 insertion(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/7280/3
--
To view, visit http://gerrit.cloudera.org:8080/7280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7280
to look at the new patch set (#2).
Change subject: Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
......................................................................
Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
With the proper fix for KUDU-2052 ready, we no longer need this workaround.
This reverts commit dbc12e4292256bc7a7a7dcee98d889eb5340c6ac.
Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_fs.cc
3 files changed, 1 insertion(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/7280/2
--
To view, visit http://gerrit.cloudera.org:8080/7280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
......................................................................
Revert "KUDU-2052: disable hole repunching at startup on xfs filesystems"
With the proper fix for KUDU-2052 ready, we no longer need this workaround.
This reverts commit 410763afa61252fa8c7125f66429bad602db795a.
Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Reviewed-on: http://gerrit.cloudera.org:8080/7280
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_fs.cc
3 files changed, 1 insertion(+), 23 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7280
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie36750f419574441c6e5d9dd10a0558eef8cdbe9
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>