You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tonghuaroot (via GitHub)" <gi...@apache.org> on 2026/06/10 15:28:38 UTC
[PR] fix(services/azdls): load Azure credentials from environment [opendal]
tonghuaroot opened a new pull request, #7725:
URL: https://github.com/apache/opendal/pull/7725
# Which issue does this PR close?
Closes #7224.
# Rationale for this change
The `azdls` builder seeded its credential environment from an empty `HashMap`,
so OS-supplied variables (e.g. AKS Workload Identity:
`AZURE_FEDERATED_TOKEN_FILE`, `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`,
`AZURE_AUTHORITY_HOST`) never reached the credential providers. Authentication
then fell back to IMDS, which does not work in AKS. The `azblob` builder
already passes the process environment through, so the two backends behaved
inconsistently.
# What changes are included in this PR?
- Seed the `azdls` credential environment from the process environment before
overlaying explicitly configured values, mirroring `azblob`. Explicit config
still takes precedence over environment variables.
- Extract the env-map construction into a small `merge_credential_envs` helper
so the override precedence can be unit-tested without mutating process state.
- Add unit tests covering both directions: OS environment variables pass
through, and explicit config overrides them.
# Are there any user-facing changes?
No public API change. Behaviorally, `azdls` now picks up Azure credentials from
environment variables (matching its documented behavior and `azblob`), which is
required for Workload Identity in AKS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/azdls): load Azure credentials from environment [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #7725:
URL: https://github.com/apache/opendal/pull/7725#issuecomment-4671906023
duplicated with https://github.com/apache/opendal/pull/7573
wait for fix from reqsign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(services/azdls): load Azure credentials from environment [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed pull request #7725: fix(services/azdls): load Azure credentials from environment
URL: https://github.com/apache/opendal/pull/7725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org