You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/06/15 20:30:42 UTC

[GitHub] [arrow-nanoarrow] jorisvandenbossche opened a new pull request, #234: build(python): use src/ layout for python package

jorisvandenbossche opened a new pull request, #234:
URL: https://github.com/apache/arrow-nanoarrow/pull/234

   Follow-up on https://github.com/apache/arrow-nanoarrow/pull/117, moving back to a src layout


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] jorisvandenbossche commented on pull request #234: build(python): use src/ layout for python package

Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #234:
URL: https://github.com/apache/arrow-nanoarrow/pull/234#issuecomment-1593695547

   @paleolimbot I didn't do anything special (apart from adding src in `python -m pytest --cov ./src/nanoarrow`), but coverage seems to be working out of the box?
   
   ```
   Name                        Stmts   Miss  Cover
   -----------------------------------------------
   src/nanoarrow/__init__.py       2      0   100%
   src/nanoarrow/_lib.pyx        314     39    88%
   src/nanoarrow/lib.py           25      3    88%
   -----------------------------------------------
   TOTAL                         341     42    88%
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot merged pull request #234: build(python): use src/ layout for python package

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #234:
URL: https://github.com/apache/arrow-nanoarrow/pull/234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-nanoarrow] paleolimbot commented on pull request #234: build(python): use src/ layout for python package

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #234:
URL: https://github.com/apache/arrow-nanoarrow/pull/234#issuecomment-1593965823

   Thank you! I assume whatever I was running into was an artifact of my Python environment (but this really just has to work on CI anyway).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org