You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/08 09:51:27 UTC
[GitHub] [spark] dchvn opened a new pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
dchvn opened a new pull request #34222:
URL: https://github.com/apache/spark/pull/34222
### What changes were proposed in this pull request?
Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Currently, there is type hint stub files to show the expected types for functions, but we can also take advantage of static type checking within the functions by inlining the type hints.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Existing test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942097703
**[Test build #144196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144196/testReport)** for PR 34222 at commit [`e79628c`](https://github.com/apache/spark/commit/e79628c48f73f8d1cddb685ea95a9d13070b7613).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938561890
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938528729
**[Test build #144018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144018/testReport)** for PR 34222 at commit [`e8ef082`](https://github.com/apache/spark/commit/e8ef082b4484f9d1cc0b6a81f0c3ed7e2bfb559d).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942143225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942191314
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48675/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #34222:
URL: https://github.com/apache/spark/pull/34222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942143225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938545273
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144018/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938537915
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942097703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938580780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938545273
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144018/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938580780
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48495/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942122589
**[Test build #144196 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144196/testReport)** for PR 34222 at commit [`e79628c`](https://github.com/apache/spark/commit/e79628c48f73f8d1cddb685ea95a9d13070b7613).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942191314
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48675/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942097703
**[Test build #144196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144196/testReport)** for PR 34222 at commit [`e79628c`](https://github.com/apache/spark/commit/e79628c48f73f8d1cddb685ea95a9d13070b7613).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942097703
**[Test build #144196 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144196/testReport)** for PR 34222 at commit [`e79628c`](https://github.com/apache/spark/commit/e79628c48f73f8d1cddb685ea95a9d13070b7613).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942143225
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144196/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-948152350
cc @ueshin , @itholic , @zero323 Please take a look here and [#34321](https://github.com/apache/spark/pull/34321) when you have time. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-942143225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938509583
**[Test build #144018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144018/testReport)** for PR 34222 at commit [`e8ef082`](https://github.com/apache/spark/commit/e8ef082b4484f9d1cc0b6a81f0c3ed7e2bfb559d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-938509583
**[Test build #144018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144018/testReport)** for PR 34222 at commit [`e8ef082`](https://github.com/apache/spark/commit/e8ef082b4484f9d1cc0b6a81f0c3ed7e2bfb559d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-948173734
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dchvn commented on pull request #34222: [SPARK-36952][PYTHON] Inline type hints for python/pyspark/resource/information.py and python/pyspark/resource/profile.py
Posted by GitBox <gi...@apache.org>.
dchvn commented on pull request #34222:
URL: https://github.com/apache/spark/pull/34222#issuecomment-948174762
Thank you @HyukjinKwon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org