You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/11/28 01:08:44 UTC
[GitHub] codecov-io edited a comment on issue #3541: Adding pluggable
storage support for realtime upload
codecov-io edited a comment on issue #3541: Adding pluggable storage support for realtime upload
URL: https://github.com/apache/incubator-pinot/pull/3541#issuecomment-442275870
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=h1) Report
> Merging [#3541](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/a834a4949e5c46d590629852697ffdc07d2d7009?src=pr&el=desc) will **decrease** coverage by `11.95%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3541 +/- ##
=============================================
- Coverage 70.8% 58.84% -11.96%
Complexity 4 4
=============================================
Files 997 1147 +150
Lines 45760 58190 +12430
Branches 6135 8054 +1919
=============================================
+ Hits 32400 34242 +1842
- Misses 11235 21577 +10342
- Partials 2125 2371 +246
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...in/java/com/linkedin/pinot/filesystem/PinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL1Bpbm90RlMuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2FwaS9yZXNvdXJjZXMvTExDU2VnbWVudENvbXBsZXRpb25IYW5kbGVycy5qYXZh) | `64.66% <73.68%> (-0.17%)` | `0 <0> (ø)` | |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | |
| [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `51.42% <0%> (-15%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `68.88% <0%> (-13.34%)` | `0% <0%> (ø)` | |
| [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `48.48% <0%> (-12.13%)` | `0% <0%> (ø)` | |
| [...kedin/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3V0aWwvU29ydGVkUmFuZ2VJbnRlcnNlY3Rpb24uamF2YQ==) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | |
| [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
| [...der/HighLevelConsumerBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvSGlnaExldmVsQ29uc3VtZXJCYXNlZFJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `90.9% <0%> (-3.04%)` | `0% <0%> (ø)` | |
| [...lix/core/realtime/PinotRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVhbHRpbWUvUGlub3RSZWFsdGltZVNlZ21lbnRNYW5hZ2VyLmphdmE=) | `72.48% <0%> (-2.12%)` | `0% <0%> (ø)` | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-pinot/pull/3541/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=footer). Last update [a834a49...343a5bf](https://codecov.io/gh/apache/incubator-pinot/pull/3541?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org