You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by st...@apache.org on 2011/02/22 19:05:19 UTC
svn commit: r1073439 - in /myfaces/extensions/cdi/trunk:
component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/
core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/
jee-mod...
Author: struberg
Date: Tue Feb 22 18:05:18 2011
New Revision: 1073439
URL: http://svn.apache.org/viewvc?rev=1073439&view=rev
Log:
code cleanup: don't catch Throwables
Modified:
myfaces/extensions/cdi/trunk/component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/TrinidadSupportModuleStartupObserver.java
myfaces/extensions/cdi/trunk/core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/SimpleLoggingTest.java
myfaces/extensions/cdi/trunk/jee-modules/bv-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/bv/impl/BeanValidationModuleStartupObserver.java
myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/JpaModuleStartupObserver.java
myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/JsfModuleStartupObserver.java
myfaces/extensions/cdi/trunk/jse-modules/scripting-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/scripting/impl/ScriptingModuleStartupObserver.java
Modified: myfaces/extensions/cdi/trunk/component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/TrinidadSupportModuleStartupObserver.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/TrinidadSupportModuleStartupObserver.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/TrinidadSupportModuleStartupObserver.java (original)
+++ myfaces/extensions/cdi/trunk/component-support-modules/trinidad-support/src/main/java/org/apache/myfaces/extensions/cdi/trinidad/impl/TrinidadSupportModuleStartupObserver.java Tue Feb 22 18:05:18 2011
@@ -54,7 +54,7 @@ public class TrinidadSupportModuleStartu
this.logger.info(info.toString());
}
//avoid that this log harms the startup
- catch (Throwable t)
+ catch (Exception t)
{
this.logger.warning("Trinidad-Support-Module couldn't log the current configuration." +
"Startup will continue!");
Modified: myfaces/extensions/cdi/trunk/core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/SimpleLoggingTest.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/SimpleLoggingTest.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/SimpleLoggingTest.java (original)
+++ myfaces/extensions/cdi/trunk/core/impl/src/test/java/org/apache/myfaces/extensions/cdi/core/test/impl/logging/SimpleLoggingTest.java Tue Feb 22 18:05:18 2011
@@ -51,7 +51,7 @@ public class SimpleLoggingTest
{
loggingClient = deserializeData(serialized);
}
- catch (Throwable e)
+ catch (Exception e)
{
fail("failed to deserialize instance of " + Logger.class.getName(), e);
}
Modified: myfaces/extensions/cdi/trunk/jee-modules/bv-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/bv/impl/BeanValidationModuleStartupObserver.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/bv-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/bv/impl/BeanValidationModuleStartupObserver.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/bv-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/bv/impl/BeanValidationModuleStartupObserver.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/bv-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/bv/impl/BeanValidationModuleStartupObserver.java Tue Feb 22 18:05:18 2011
@@ -53,7 +53,7 @@ public class BeanValidationModuleStartup
this.logger.info(info.toString());
}
//avoid that this log harms the startup
- catch (Throwable t)
+ catch (Exception t)
{
this.logger.warning("Bean-Validation-Module couldn't log the current configuration." +
"Startup will continue!");
Modified: myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/JpaModuleStartupObserver.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/JpaModuleStartupObserver.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/JpaModuleStartupObserver.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/jpa-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jpa/impl/JpaModuleStartupObserver.java Tue Feb 22 18:05:18 2011
@@ -54,7 +54,7 @@ public class JpaModuleStartupObserver ex
this.logger.info(info.toString());
}
//avoid that this log harms the startup
- catch (Throwable t)
+ catch (Exception t)
{
this.logger.warning("JPA-Module couldn't log the current configuration." +
"Startup will continue!");
Modified: myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/JsfModuleStartupObserver.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/JsfModuleStartupObserver.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/JsfModuleStartupObserver.java (original)
+++ myfaces/extensions/cdi/trunk/jee-modules/jsf-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/jsf/impl/JsfModuleStartupObserver.java Tue Feb 22 18:05:18 2011
@@ -90,7 +90,7 @@ public class JsfModuleStartupObserver ex
this.logger.info(info.toString());
}
//avoid that this log harms the startup
- catch (Throwable t)
+ catch (Exception t)
{
this.logger.warning("JSF-Module couldn't log the current configuration." +
"Startup will continue!");
Modified: myfaces/extensions/cdi/trunk/jse-modules/scripting-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/scripting/impl/ScriptingModuleStartupObserver.java
URL: http://svn.apache.org/viewvc/myfaces/extensions/cdi/trunk/jse-modules/scripting-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/scripting/impl/ScriptingModuleStartupObserver.java?rev=1073439&r1=1073438&r2=1073439&view=diff
==============================================================================
--- myfaces/extensions/cdi/trunk/jse-modules/scripting-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/scripting/impl/ScriptingModuleStartupObserver.java (original)
+++ myfaces/extensions/cdi/trunk/jse-modules/scripting-module/impl/src/main/java/org/apache/myfaces/extensions/cdi/scripting/impl/ScriptingModuleStartupObserver.java Tue Feb 22 18:05:18 2011
@@ -54,7 +54,7 @@ public class ScriptingModuleStartupObser
this.logger.info(info.toString());
}
//avoid that this log harms the startup
- catch (Throwable t)
+ catch (Exception t)
{
this.logger.warning("Scripting-Module couldn't log the current configuration." +
"Startup will continue!");