You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/26 07:59:36 UTC
[GitHub] [flink] snuyanzin opened a new pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
snuyanzin opened a new pull request #17922:
URL: https://github.com/apache/flink/pull/17922
## What is the purpose of the change
There are some problem queries with misprints like
```sql
ELECT 1;
/*
comment
*/ SEECT 1;
```
Currently SQL client responses for such queries like `Non-query expression encountered in illegal context`. For larger queries it could be a time consuming task to understand what is wrong.
The PR is aimed to provide more info for such queries like exact unknown token and start position. So it will help to faster detect issues. In fact this info is already present in `SqlParseException` in `pos` field.
## Brief change log
In case of `SqlParseException` and message `Non-query expression encountered in illegal context` extract and show `pos` info
## Verifying this change
There are tests added to _flink-table/flink-sql-client/src/test/resources/sql/select.q_
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
}, {
"hash" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0da32f3c2adc229059a22c6af19dea04d3605da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108)
* c1d3a50d01717a714c92f63b928c5e84e975ec67 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0da32f3c2adc229059a22c6af19dea04d3605da UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
}, {
"hash" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32240",
"triggerID" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1d3a50d01717a714c92f63b928c5e84e975ec67 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32240)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0da32f3c2adc229059a22c6af19dea04d3605da Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
}, {
"hash" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32240",
"triggerID" : "c1d3a50d01717a714c92f63b928c5e84e975ec67",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0da32f3c2adc229059a22c6af19dea04d3605da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108)
* c1d3a50d01717a714c92f63b928c5e84e975ec67 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=32240)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766109
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e0da32f3c2adc229059a22c6af19dea04d3605da (Fri Nov 26 08:02:13 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24908).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17922: [FLINK-24908][Table SQL/Client] Improve SQL Error description for SQL Client
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17922:
URL: https://github.com/apache/flink/pull/17922#issuecomment-979766429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108",
"triggerID" : "e0da32f3c2adc229059a22c6af19dea04d3605da",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e0da32f3c2adc229059a22c6af19dea04d3605da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=27108)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org