[GitHub] [airflow] turbaszek commented on a change in pull request #9140: Fix gzip option of sql_to_gcs operator

[GitBox <gi...@apache.org>]

turbaszek commented on a change in pull request #9140:
URL: https://github.com/apache/airflow/pull/9140#discussion_r435269890



##########
File path: airflow/providers/google/cloud/operators/sql_to_gcs.py
##########
@@ -292,4 +292,4 @@ def _upload_to_gcs(self, files_to_upload):
             hook.upload(self.bucket, tmp_file.get('file_name'),
                         tmp_file.get('file_handle').name,
                         mime_type=tmp_file.get('file_mime_type'),
-                        gzip=self.gzip if tmp_file.get('file_name') == self.schema_filename else False)
+                        gzip=self.gzip if tmp_file.get('file_name') != self.schema_filename else False)

Review comment:
       Should we add a warning in init if both gzip and schema are provided?
   ```
   :param gzip: Option to compress file for upload (does not apply to schemas).
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org