You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/06/11 00:14:33 UTC

[GitHub] [bookkeeper] Shoothzj commented on a diff in pull request #3314: Remove gradle from workflow

Shoothzj commented on code in PR #3314:
URL: https://github.com/apache/bookkeeper/pull/3314#discussion_r894949940


##########
.github/workflows/backward-compat-tests.yml:
##########
@@ -49,10 +49,17 @@ jobs:
         with:
           java-version: 1.8
       - name: Build
-        run: ./gradlew stream:server:build -x test ${GRADLE_ARGS}
+        run: mvn -B -nsu -am -pl :stream-storage-server clean install
       - name: Test current server with old clients
-        run: ./gradlew :tests:backward-compat:current-server-old-clients:test ${GRADLE_ARGS} || (tail -n +1 tests/backward-compat/current-server-old-clients/build/reports/tests/test/classes/* && tail -n +1 tests/backward-compat/current-server-old-clients/build/container-logs/**/* && exit 1)
+        run: mvn -B -nsu -am -pl :backward-compat-current-server-old-clients test

Review Comment:
   @nicoloboschi `-am` only compile the module, it will not run tests. And it's needed, otherwise the test module can't compile success.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org