[jira] [Commented] (PHOENIX-3296) ArrayConstructor expression does not serialize arrays with leading nulls correctly.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-3296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550890#comment-15550890 ] 

Hadoop QA commented on PHOENIX-3296:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12831885/PHOENIX-3296.patch
  against master branch at commit 34ba28e60f66cb7b537b60c9ef04b8a26036f010.
  ATTACHMENT ID: 12831885

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 38 warning messages.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        ArrayConstructorExpression arrayConstructorExpression = new ArrayConstructorExpression(children, PVarbinary.INSTANCE, false);
+        LiteralExpression literalExpression = new LiteralExpression(PVarbinaryArray.INSTANCE, ptr.copyBytes());

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/616//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/616//artifact/patchprocess/patchReleaseAuditWarnings.txt
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/616//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/616//console

This message is automatically generated.

> ArrayConstructor expression does not serialize arrays with leading nulls correctly.
> -----------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3296
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3296
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3296.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)