You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Brian Havard <br...@kheldar.apana.org.au> on 1999/02/09 15:49:16 UTC
[PATCH] Allow drive letters in UserDir directive in OS/2
The 'Crummy hack' for drive letters done for Win32 is needed in OS/2 as well.
I reckon we need a 'HAVE_DRIVE_LETTERS' define instead of using 'if Win32 or
OS2' everywhere. Should I make a patch to do this?
Index: mod_userdir.c
===================================================================
RCS file: /cvs/apache-1.3/src/modules/standard/mod_userdir.c,v
retrieving revision 1.38
diff -u -r1.38 mod_userdir.c
--- mod_userdir.c 1999/01/01 19:05:15 1.38
+++ mod_userdir.c 1999/02/09 13:38:33
@@ -262,7 +262,7 @@
if (userdir[0] == '\0' || ap_os_is_path_absolute(userdir)) {
if (x) {
-#ifdef WIN32
+#if defined(WIN32) || defined(OS2)
/*
* Crummy hack. Need to figure out whether we have been
* redirected to a URL or to a file on some drive. Since I
--
______________________________________________________________________________
| Brian Havard | "He is not the messiah! |
| brianh@kheldar.apana.org.au | He's a very naughty boy!" - Life of Brian |
------------------------------------------------------------------------------
Re: [PATCH] Allow drive letters in UserDir directive in OS/2
Posted by Ben Laurie <be...@algroup.co.uk>.
Brian Havard wrote:
>
> The 'Crummy hack' for drive letters done for Win32 is needed in OS/2 as well.
>
> I reckon we need a 'HAVE_DRIVE_LETTERS' define instead of using 'if Win32 or
> OS2' everywhere. Should I make a patch to do this?
Yes!
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"My grandfather once told me that there are two kinds of people: those
who work and those who take the credit. He told me to try to be in the
first group; there was less competition there."
- Indira Gandhi
Re: [PATCH] Allow drive letters in UserDir directive in OS/2
Posted by Paul Sutton <pa...@awe.com>.
On Wed, 10 Feb 1999, Brian Havard wrote:
> The 'Crummy hack' for drive letters done for Win32 is needed in OS/2 as well.
>
> I reckon we need a 'HAVE_DRIVE_LETTERS' define instead of using 'if Win32 or
> OS2' everywhere. Should I make a patch to do this?
Absolutely.
Paul