[GitHub] [camel-k] davsclaus edited a comment on pull request #2831: feat(api): Add YAML DSL structural schema to CRDs

[GitBox <gi...@apache.org>]

davsclaus edited a comment on pull request #2831:
URL: https://github.com/apache/camel-k/pull/2831#issuecomment-994634246


   About the kamelet changes, if its an internal change with `flow` -> `template`, then maybe we do not have to bump it to a 1.0.x release. I assume from end user point of view, it works just the same.
   
   In camel-yaml-dsl and camel-kamelet - then I wonder if we have code that checks for both `flow` and `template`. Yes we do:
   ```
           Node template = nodeAt(node, "/spec/template");
           if (template == null) {
               // fallback till flows get removed
               template = nodeAt(node, "/spec/flows");
           }
           if (template == null) {
               // fallback till flow get removed
               template = nodeAt(node, "/spec/flow");
           }
           if (template == null) {
               throw new IllegalArgumentException("No template defined");
           }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org