You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/25 15:01:59 UTC

[GitHub] [pulsar] lhotari edited a comment on pull request #9673: [Testing] Improve LocalRunner to support .nar files that aren't on the classpath

lhotari edited a comment on pull request #9673:
URL: https://github.com/apache/pulsar/pull/9673#issuecomment-785038317


   > Can you handle "cleanup and shutdown isn't handled in tests" first?
   
   Hi @sijie . Thanks for the review.
   I can do this, however I think there's a justification to put multiple related changes together because the Pulsar CI is in such bad shape. It's pretty painful to get even a single PR to pass all the flaky tests. 
   
   > I am not sure how the refactor will handle PIP-62 yet. Can we defer that until it is actually happening? Let's avoid over-engineering now.
   
   There's no need to couple these changes with PIP-62. This PR fixes clear problems in LocalRunner. What makes you think that this is over-engineering?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org