You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/06 15:35:12 UTC
[GitHub] [airflow] eladkal opened a new issue, #28768: Add pre-commit to prevent using xfail tests
eladkal opened a new issue, #28768:
URL: https://github.com/apache/airflow/issues/28768
### Body
Related https://github.com/apache/airflow/issues/23539
xfail means that you expect a test to fail for some reason.
If we expect a test to fail it should simply be a regular test that make sure the relevant logic fails and in that case we finish the test with success.|
There should be no cases where we see tests ends in failure yet we consider it good - this is very confusing.
This task is about writing pre-commit that will make sure we don't add any xfail test to the project.
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal closed issue #28768: Add pre-commit to prevent using xfail tests
Posted by GitBox <gi...@apache.org>.
eladkal closed issue #28768: Add pre-commit to prevent using xfail tests
URL: https://github.com/apache/airflow/issues/28768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #28768: Add pre-commit to prevent using xfail tests
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #28768:
URL: https://github.com/apache/airflow/issues/28768#issuecomment-1373871341
> But what would be used instead if I do want to mark a test as xfail, i.e. it should pass but currently does not (due to certain reasons, perhaps bugs in dependencies)?
If test is flaky it should be mark as quarantined
https://github.com/apache/airflow/issues/28658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on issue #28768: Add pre-commit to prevent using xfail tests
Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #28768:
URL: https://github.com/apache/airflow/issues/28768#issuecomment-1373864949
But what would be used instead if I do want to mark a test as xfail, i.e. it should pass but currently does not (due to certain reasons, perhaps bugs in dependencies)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #28768: Add pre-commit to prevent using xfail tests
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #28768:
URL: https://github.com/apache/airflow/issues/28768#issuecomment-1373954327
By the way if for some reason we must use xfail then its OK to have a list of exclusions but this needs to be intentional by the PR author and verified by reviewer so we can avoid cases like we have now where xfail was used when not really needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org