You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "hvanhovell (via GitHub)" <gi...@apache.org> on 2024/08/29 01:19:01 UTC
Re: [PR] [SPARK-41811][PYTHON][CONNECT] Implement `SQLStringFormatter` with `WithRelations` [spark]
hvanhovell commented on code in PR #45614:
URL: https://github.com/apache/spark/pull/45614#discussion_r1735449966
##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -61,7 +61,7 @@ message Command {
// almost oblivious to the server-side behavior.
message SqlCommand {
// (Required) SQL Query.
- string sql = 1;
+ string sql = 1 [deprecated=true];
Review Comment:
@zhengruifeng where am I supposed to set the sql text now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org