You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2008/02/24 18:13:56 UTC

Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c

rpluem@apache.org wrote:
> -    apr_size_t written;
> +    int written;

FYI - int is < apr_ssize_t, please flip that to a signed representation
that corresponds to sizeof(void*)

Bill

Re: svn commit: r630625 - /apr/apr-util/trunk/buckets/apr_brigade.c

Posted by Ruediger Pluem <rp...@apache.org>.


On 02/24/2008 06:13 PM, William A. Rowe, Jr. wrote:
> rpluem@apache.org wrote:
>> -    apr_size_t written;
>> +    int written;
> 
> FYI - int is < apr_ssize_t, please flip that to a signed representation
> that corresponds to sizeof(void*)

Sorry that I don't get it but

- apr_vformatter returns an 'int'
- we only use 'written' later on to compare it against -1. Nothing else
   is done with 'written' afterwards.

So where is the point in using a signed representation that corresponds to
sizeof(void*)?

Regards

Rüdiger