You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fury.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2024/01/03 15:16:34 UTC
[I] Consider to rewrite shell scripts in Python [incubator-fury]
PragmaTwice opened a new issue, #1299:
URL: https://github.com/apache/incubator-fury/issues/1299
TBH these scripts are hard to maintain (especially considering the difference between bash and zsh), we need a more structure language like python to make them readable and maintanable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Consider to rewrite shell scripts in Python [incubator-fury]
Posted by "LiangliangSui (via GitHub)" <gi...@apache.org>.
LiangliangSui commented on issue #1299:
URL: https://github.com/apache/incubator-fury/issues/1299#issuecomment-1876221665
So can we start by rewriting the C++ CI Build script in Windows? such as `run_ci.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Consider to rewrite shell scripts in Python [incubator-fury]
Posted by "LiangliangSui (via GitHub)" <gi...@apache.org>.
LiangliangSui commented on issue #1299:
URL: https://github.com/apache/incubator-fury/issues/1299#issuecomment-1875555120
I totally agree with this, it can mask the differences in script syntax (e.g. windows script syntax is very unfriendly), and it is easier to write and code readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Consider to rewrite shell scripts in Python [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1299:
URL: https://github.com/apache/incubator-fury/issues/1299#issuecomment-1875633128
This remind me of `PyTorch`. When you filing an issue, you can execute a python script from `PyTorch`, which can collect system information as much as it can, and print it. Then you can paste such information into the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Consider to rewrite shell scripts in Python [fory]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang closed issue #1299: Consider to rewrite shell scripts in Python
URL: https://github.com/apache/fory/issues/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fory.apache.org
For additional commands, e-mail: commits-help@fory.apache.org
Re: [I] Consider to rewrite shell scripts in Python [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1299:
URL: https://github.com/apache/incubator-fury/issues/1299#issuecomment-1875630437
Sounds good to me, but rewriting those scripts into python is not an easy work, and most scripts are used by CI only. I suggest we start from rewriting the scripts used by contributors everyday.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org
Re: [I] Consider to rewrite shell scripts in Python [incubator-fury]
Posted by "chaokunyang (via GitHub)" <gi...@apache.org>.
chaokunyang commented on issue #1299:
URL: https://github.com/apache/incubator-fury/issues/1299#issuecomment-1876247200
Yep, we can start from rewriting the C++ CI Build script in Windows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fury.apache.org
For additional commands, e-mail: commits-help@fury.apache.org