Re: [PR] Get rid of deprecated assertThat() usages [lucene]

["sabi0 (via GitHub)" <gi...@apache.org>]

sabi0 commented on code in PR #12982:
URL: https://github.com/apache/lucene/pull/12982#discussion_r1445816935


##########
lucene/suggest/src/test/org/apache/lucene/search/suggest/document/TestSuggestField.java:
##########
@@ -485,7 +470,7 @@ public void testNRTDeletedDocFiltering() throws Exception {
     PrefixCompletionQuery query =
         new PrefixCompletionQuery(analyzer, new Term("suggest_field", "abc_"));
     TopSuggestDocs suggest = indexSearcher.suggest(query, numLive, false);
-    assertSuggestions(suggest, expectedEntries.toArray(new Entry[expectedEntries.size()]));
+    assertSuggestions(suggest, expectedEntries.toArray(new Entry[0]));

Review Comment:
   I had a closer look at the `assertSuggestions()` method. It has 56 usages in 6 different classes.
   So here are the options I see:
   1. return pre-calculated array sizes and keep this part as is
   2. overload the method to accept either `Entry...` or `Collection<Entry>` and update the 13 usages in the `TestSuggestField` (leaving the other classes for later)
   3. proceed with the refactoring to `Collection<Entry>` and update all 6 classes (in a separate PR)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org