[jira] [Commented] (STORM-2164) Create simple generic plugin system to register codahale reporters

["Alessandro Bellina (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15713212#comment-15713212 ] 

Alessandro Bellina commented on STORM-2164:
-------------------------------------------

[~ptgoetz] just a quick update... reporter stuff should be ready to push for our WIP branch. No tests yet.. but I did take the PreparableReporter stuff and moved it over to metrics2 namespace. 

This is the type of config I have right now:

{code}
storm.metrics.reporters:
     "graphite":  
         class: "org.apache.storm.metrics2.reporters.GraphitePreparableReporter"
         daemons:
             - "supervisor"
             - "nimbus"
         schedule.period: 60
         schedule.period.units: "SECONDS"
         target.host: "localhost"
         target.port: 2003

     "default":
         class: "org.apache.storm.metrics2.reporters.StormPreparableReporter"
         daemons:
             - "worker"
         schedule.period: 10
         schedule.period.units: "SECONDS"
         rate.units: "SECONDS"
         duration.units: "SECONDS"
{code}

So very similar to your suggestion, but in this case I have names per reporter (so you could have two instances say), and the daemons collection. The daemon passes DaemonType/WORKER say and will instantiate reporters that match. 

> Create simple generic plugin system to register codahale reporters
> ------------------------------------------------------------------
>
>                 Key: STORM-2164
>                 URL: https://issues.apache.org/jira/browse/STORM-2164
>             Project: Apache Storm
>          Issue Type: Improvement
>            Reporter: Alessandro Bellina
>            Assignee: Alessandro Bellina
>
> Configurable plugin interface s.t. daemons can instantiate codahale reporters.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)