You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/09 16:43:10 UTC
[GitHub] [incubator-iotdb] neuyilan opened a new pull request #1339: [IOTDB-723] add raft log delete mechanism
neuyilan opened a new pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339
The main logic for deleting raft logs is as follows:
Each server periodically(3600 seconds) triggers the operation to check the deletion of the log. If the distance between the last deletion log index and the current maximum commited index exceeds a certain threshold, it performs the deletion operation, otherwise do nothing.
please leave your opinions, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1339: [IOTDB-723] add raft log delete mechanism
Posted by GitBox <gi...@apache.org>.
jt2594838 commented on a change in pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#discussion_r437844557
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/serializable/SyncLogDequeSerializer.java
##########
@@ -79,6 +85,24 @@
// version controller
private VersionController versionController;
+ private ScheduledExecutorService executorService;
+
+
+ /**
+ * the max number of committed logs to be saved
+ */
+ private int maxNumberLogs = 100;
Review comment:
It would be better to put this into the configs.
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##########
@@ -50,6 +54,17 @@
private long commitIndex;
private LogApplier logApplier;
+ /**
+ * the max number of committed logs to be saved
+ */
+ private int maxNumberLogs = 100;
Review comment:
It would be better to make this a config.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1339: [IOTDB-723] add raft log delete mechanism
Posted by GitBox <gi...@apache.org>.
neuyilan commented on a change in pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#discussion_r437896543
##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/manage/RaftLogManager.java
##########
@@ -50,6 +54,17 @@
private long commitIndex;
private LogApplier logApplier;
+ /**
+ * the max number of committed logs to be saved
+ */
+ private int maxNumberLogs = 100;
Review comment:
I have put the MAX_NUMBER_OF_LOGS and LOG_DELETION_CHECK_INTERVAL_SECOND in iotdb-cluster.properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jt2594838 merged pull request #1339: [IOTDB-723] add raft log delete mechanism
Posted by GitBox <gi...@apache.org>.
jt2594838 merged pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl commented on pull request #1339: [IOTDB-723] add raft log delete mechanism
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#issuecomment-641671481
How about the raft logs in Memory(CommittedLogManager)?Is it better to make them consistent after deleting old logs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] LebronAl commented on pull request #1339: [IOTDB-723] add raft log delete mechanism
Posted by GitBox <gi...@apache.org>.
LebronAl commented on pull request #1339:
URL: https://github.com/apache/incubator-iotdb/pull/1339#issuecomment-641759183
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org