You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/03 08:48:51 UTC
[GitHub] [apisix-dashboard] foolwc opened a new pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
foolwc opened a new pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
improve grid layout for Upstream components when screen width between 992px and 1600px.
**Related issues**
resolve #2016
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030#issuecomment-891684324
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2030](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (25ccc38) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/fe6e155e2a1471dbe696b004c7524de46afb0232?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fe6e155) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 25ccc38 differs from pull request most recent head fe1fd9f. Consider uploading reports for the commit fe1fd9f to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2030 +/- ##
=======================================
Coverage 64.03% 64.03%
=======================================
Files 121 121
Lines 3156 3156
Branches 753 753
=======================================
Hits 2021 2021
Misses 1135 1135
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `64.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Upstream/components/Nodes.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2030/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvTm9kZXMudHN4) | `100.00% <ø> (ø)` | |
| [...m/components/active-check/Healthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2030/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL0hlYWx0aHkvSHR0cFN0YXR1c2VzLnRzeA==) | `8.33% <ø> (ø)` | |
| [...components/active-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2030/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwU3RhdHVzZXMudHN4) | `8.33% <ø> (ø)` | |
| [web/src/components/Upstream/constant.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/2030/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbnN0YW50LnRz) | `100.00% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fe6e155...fe1fd9f](https://codecov.io/gh/apache/apisix-dashboard/pull/2030?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] foolwc commented on pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
Posted by GitBox <gi...@apache.org>.
foolwc commented on pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030#issuecomment-894016832
please help me review this PR. Thanks @LiteSun @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030#issuecomment-891660569
👷 Deploy Preview for *apisix-dashboard* processing.
🔨 Explore the source changes: fe1fd9f6d168ea10061384114b2f777d22c19d91
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610902e63556310008432b02](https://app.netlify.com/sites/apisix-dashboard/deploys/610902e63556310008432b02?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2030: perf(Upstream): improve grid layout for Upstream components when screen width between 992px and 1600px
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2030:
URL: https://github.com/apache/apisix-dashboard/pull/2030#issuecomment-891660569
✔️ Deploy Preview for *apisix-dashboard* ready!
🔨 Explore the source changes: fe1fd9f6d168ea10061384114b2f777d22c19d91
🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610902e63556310008432b02](https://app.netlify.com/sites/apisix-dashboard/deploys/610902e63556310008432b02?utm_source=github&utm_campaign=bot_dl)
😎 Browse the preview: [https://deploy-preview-2030--apisix-dashboard.netlify.app/](https://deploy-preview-2030--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org