[GitHub] [netbeans] matthiasblaesing commented on pull request #2600: First attempt add LSP-based rename refactoring to the Java LSP Server and the LSP Client.

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2600:
URL: https://github.com/apache/netbeans/pull/2600#issuecomment-751500584


   I think this is worth merging. I looked only at the client part though. I suggest to apply the commits from this branch:
   
   https://github.com/matthiasblaesing/netbeans/tree/pr-2600:
   
   https://github.com/matthiasblaesing/netbeans/commit/4c865767568f091041c03d511757a533099d4427: Merge master
   https://github.com/matthiasblaesing/netbeans/commit/52feaf755c926ee8af6a56993580c15b85df5397: Implement basic support for cancelability (primary intention: don't raise an `UnsupportedOperationException`.
   https://github.com/matthiasblaesing/netbeans/commit/26487ddd3a7285fbbcd25eb8c624536af016870b: Register the rename refactoring into the menu of the filetypes
   https://github.com/matthiasblaesing/netbeans/commit/1618fb4bfd9c5c8060b5ea4d2b6e065e5824671f: Prevent exceptions about locking
   
   @jlahoda It would be great to get this in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists