[GitHub] [hudi] danny0405 commented on pull request #7886: [HUDI-5726]Fix timestamp field is 8 hours longer than the time

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on PR #7886:
URL: https://github.com/apache/hudi/pull/7886#issuecomment-1435479739

   
   Thanks for the contribution, I have reviewed and attached a patch here: [HUDI-5726.patch.zip](https://github.com/apache/hudi/files/10773066/HUDI-5726.patch.zip)
   
   The overall principle is that Flink does not do any TimeZone shift for the input timestamp, because Flink `TimestampData` is with UTC timezone by default(see the details how it is transformed to a Timestamp or LocalDateTime), so keep the values as is should be more straight-forward here. Same behavior is also kept for the reader, just read the values as is.
   
   With that basis, we force a UTC timezone for bulk_insert, which is kept in line with Hoodie default parquet writers.
   
   There is an optional option for flink parquet reader to shift the timestamp with local timezone, but we should be cautious with that, it is tricky in some cases especially when some other systems assume a local timezone semantics aka Hive.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org